* netfilter: ctnetlink: fix expectation mask dump
@ 2010-01-21 10:19 Patrick McHardy
0 siblings, 0 replies; only message in thread
From: Patrick McHardy @ 2010-01-21 10:19 UTC (permalink / raw)
To: Netfilter Development Mailinglist; +Cc: Pablo Neira Ayuso
[-- Attachment #1: Type: text/plain, Size: 137 bytes --]
I'm about to commit the following two bugfixes to nf-2.6.git.
I'll wait for a few hours in case someone wants to comment or
add an Ack.
[-- Attachment #2: 01.diff --]
[-- Type: text/x-patch, Size: 933 bytes --]
commit 0f682015a83fad33869f49b941adf682b4b4394c
Author: Patrick McHardy <kaber@trash.net>
Date: Thu Jan 21 11:08:52 2010 +0100
netfilter: ctnetlink: fix expectation mask dump
The protocol number is not initialized, so userspace can't interpret
the layer 4 data properly.
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index 79478df..5443a04 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -1446,8 +1446,9 @@ ctnetlink_exp_dump_mask(struct sk_buff *skb,
struct nlattr *nest_parms;
memset(&m, 0xFF, sizeof(m));
- m.src.u.all = mask->src.u.all;
memcpy(&m.src.u3, &mask->src.u3, sizeof(m.src.u3));
+ m.src.u.all = mask->src.u.all;
+ m.dst.protonum = tuple->dst.protonum;
nest_parms = nla_nest_start(skb, CTA_EXPECT_MASK | NLA_F_NESTED);
if (!nest_parms)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-01-21 10:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-21 10:19 netfilter: ctnetlink: fix expectation mask dump Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).