From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: shanwei@cn.fujitsu.com, yasuyuki.kozakai@toshiba.co.jp,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] IPv6: conntrack: Use protocol-related initialization routine to initial queues of IPv6 connection track
Date: Tue, 26 Jan 2010 16:46:06 +0100 [thread overview]
Message-ID: <4B5F0E3E.2070001@trash.net> (raw)
In-Reply-To: <20100126.051147.256313206.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Tue, 26 Jan 2010 13:46:46 +0100
>
>> Oops, sorry. Not sure why I missed this, I've successfully
>> tested that change multiple times.
>
> This situation is error prone, and I don't blame you for not catching
> it, because these common ipv6 fragmentation functions are assuming
> things about the layout of the first few struct members of the
> container in which the top level data structure lives.
>
> What should happen is that when such an assumption exists, it should
> be explicitly codified.
>
> Just like how we embed struct sock_common in both struct socket
> and in the TCP time-wait minisockets.
I'll see if I can come up with something to catch this kind of mistake
in the future.
>
> Anyways, meanwhile I'll apply the fix. And yes I know it needs
> to go to stable too... :-)
Thanks :)
next prev parent reply other threads:[~2010-01-26 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 2:31 [PATCH 1/2] IPv6: conntrack: Use protocol-related initialization routine to initial queues of IPv6 connection track Shan Wei
2010-01-26 7:32 ` David Miller
2010-01-26 12:40 ` Shan Wei
2010-01-26 12:46 ` Patrick McHardy
2010-01-26 13:11 ` David Miller
2010-01-26 15:46 ` Patrick McHardy [this message]
2010-10-30 18:41 ` Pascal Hambourg
2010-01-26 12:56 ` Yasuyuki KOZAKAI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5F0E3E.2070001@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shanwei@cn.fujitsu.com \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).