From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: "Helight.Xu" <helight.xu@gmail.com>,
netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org
Subject: Re: [REPORT] may be wrong place #endif in include/linux/netfilter_ipv4.h
Date: Mon, 01 Feb 2010 15:00:02 +0100 [thread overview]
Message-ID: <4B66DE62.8080801@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.01.1001311019430.15188@obet.zrqbmnf.qr>
Jan Engelhardt wrote:
> On Sunday 2010-01-31 03:13, Helight.Xu wrote:
>
>> hi all gys:
>>
>> when I make LKM with netfilter on "NF_IP_PRE_ROUTING" point, but it was
>> reported that "NF_IP_PRE_ROUTING" is not defined.
>>
>> but I am surely including <linux/netfilter_ipv4.h>, when I opened
>> include/linux/netfilter_ipv4.h I found that
>> "NF_IP_PRE_ROUTING" is in this lable :
>> #ifndef __KERNEL__
>> .....
>> /* IP Hooks */
>> /* After promisc drops, checksum checks. */
>> #define NF_IP_PRE_ROUTING 0
>> /* If the packet is destined for this box. */
>> #define NF_IP_LOCAL_IN 1
>> /* If the packet is destined for another interface. */
>> #define NF_IP_FORWARD 2
>> /* Packets coming from a local process. */
>> #define NF_IP_LOCAL_OUT 3
>> /* Packets about to hit the wire. */
>> #define NF_IP_POST_ROUTING 4
>> #define NF_IP_NUMHOOKS 5
>> #endif /* ! __KERNEL__ */
>>
>> So I think the "endif" is ended a little early!
>
> Seems so. Are there any out-of-tree nf_ip_hook_priorities users? If not,
> we could possibly move it further below.
Its only available for userspace for compatibility reasons,
the kernel doesn't use the old definitions.
prev parent reply other threads:[~2010-02-01 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 2:13 [REPORT] may be wrong place #endif in include/linux/netfilter_ipv4.h Helight.Xu
2010-01-31 9:21 ` Jan Engelhardt
2010-02-01 14:00 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B66DE62.8080801@trash.net \
--to=kaber@trash.net \
--cc=coreteam@netfilter.org \
--cc=helight.xu@gmail.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).