* [REPORT] may be wrong place #endif in include/linux/netfilter_ipv4.h
@ 2010-01-31 2:13 Helight.Xu
2010-01-31 9:21 ` Jan Engelhardt
0 siblings, 1 reply; 3+ messages in thread
From: Helight.Xu @ 2010-01-31 2:13 UTC (permalink / raw)
To: netfilter, netfilter-devel, Patrick McHardy, coreteam; +Cc: linux-kernel
hi all gys:
when I make LKM with netfilter on "NF_IP_PRE_ROUTING" point, but it
was reported that "NF_IP_PRE_ROUTING" is not defined.
but I am surely including <linux/netfilter_ipv4.h>, when I opened
include/linux/netfilter_ipv4.h I found that
"NF_IP_PRE_ROUTING" is in this lable :
#ifndef __KERNEL__
.....
/* IP Hooks */
/* After promisc drops, checksum checks. */
#define NF_IP_PRE_ROUTING 0
/* If the packet is destined for this box. */
#define NF_IP_LOCAL_IN 1
/* If the packet is destined for another interface. */
#define NF_IP_FORWARD 2
/* Packets coming from a local process. */
#define NF_IP_LOCAL_OUT 3
/* Packets about to hit the wire. */
#define NF_IP_POST_ROUTING 4
#define NF_IP_NUMHOOKS 5
#endif /* ! __KERNEL__ */
So I think the "endif" is ended a little early!
--
Zhenwen Xu - Seven Helight
Home Page: http://zhwen.org
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [REPORT] may be wrong place #endif in include/linux/netfilter_ipv4.h
2010-01-31 2:13 [REPORT] may be wrong place #endif in include/linux/netfilter_ipv4.h Helight.Xu
@ 2010-01-31 9:21 ` Jan Engelhardt
2010-02-01 14:00 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: Jan Engelhardt @ 2010-01-31 9:21 UTC (permalink / raw)
To: Helight.Xu
Cc: netfilter, netfilter-devel, Patrick McHardy, coreteam,
linux-kernel
On Sunday 2010-01-31 03:13, Helight.Xu wrote:
> hi all gys:
>
> when I make LKM with netfilter on "NF_IP_PRE_ROUTING" point, but it was
> reported that "NF_IP_PRE_ROUTING" is not defined.
>
> but I am surely including <linux/netfilter_ipv4.h>, when I opened
> include/linux/netfilter_ipv4.h I found that
> "NF_IP_PRE_ROUTING" is in this lable :
> #ifndef __KERNEL__
> .....
> /* IP Hooks */
> /* After promisc drops, checksum checks. */
> #define NF_IP_PRE_ROUTING 0
> /* If the packet is destined for this box. */
> #define NF_IP_LOCAL_IN 1
> /* If the packet is destined for another interface. */
> #define NF_IP_FORWARD 2
> /* Packets coming from a local process. */
> #define NF_IP_LOCAL_OUT 3
> /* Packets about to hit the wire. */
> #define NF_IP_POST_ROUTING 4
> #define NF_IP_NUMHOOKS 5
> #endif /* ! __KERNEL__ */
>
> So I think the "endif" is ended a little early!
Seems so. Are there any out-of-tree nf_ip_hook_priorities users? If not,
we could possibly move it further below.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [REPORT] may be wrong place #endif in include/linux/netfilter_ipv4.h
2010-01-31 9:21 ` Jan Engelhardt
@ 2010-02-01 14:00 ` Patrick McHardy
0 siblings, 0 replies; 3+ messages in thread
From: Patrick McHardy @ 2010-02-01 14:00 UTC (permalink / raw)
To: Jan Engelhardt
Cc: Helight.Xu, netfilter, netfilter-devel, coreteam, linux-kernel
Jan Engelhardt wrote:
> On Sunday 2010-01-31 03:13, Helight.Xu wrote:
>
>> hi all gys:
>>
>> when I make LKM with netfilter on "NF_IP_PRE_ROUTING" point, but it was
>> reported that "NF_IP_PRE_ROUTING" is not defined.
>>
>> but I am surely including <linux/netfilter_ipv4.h>, when I opened
>> include/linux/netfilter_ipv4.h I found that
>> "NF_IP_PRE_ROUTING" is in this lable :
>> #ifndef __KERNEL__
>> .....
>> /* IP Hooks */
>> /* After promisc drops, checksum checks. */
>> #define NF_IP_PRE_ROUTING 0
>> /* If the packet is destined for this box. */
>> #define NF_IP_LOCAL_IN 1
>> /* If the packet is destined for another interface. */
>> #define NF_IP_FORWARD 2
>> /* Packets coming from a local process. */
>> #define NF_IP_LOCAL_OUT 3
>> /* Packets about to hit the wire. */
>> #define NF_IP_POST_ROUTING 4
>> #define NF_IP_NUMHOOKS 5
>> #endif /* ! __KERNEL__ */
>>
>> So I think the "endif" is ended a little early!
>
> Seems so. Are there any out-of-tree nf_ip_hook_priorities users? If not,
> we could possibly move it further below.
Its only available for userspace for compatibility reasons,
the kernel doesn't use the old definitions.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-01 14:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-31 2:13 [REPORT] may be wrong place #endif in include/linux/netfilter_ipv4.h Helight.Xu
2010-01-31 9:21 ` Jan Engelhardt
2010-02-01 14:00 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).