From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fwestphal@astaro.com>
Subject: Re: [PATCH 02/10] netfilter: ebtables: avoid explicit XT_ALIGN() in match/targets
Date: Mon, 15 Feb 2010 18:40:44 +0100 [thread overview]
Message-ID: <4B79871C.5000609@trash.net> (raw)
In-Reply-To: <1265897559-10610-3-git-send-email-fw@strlen.de>
Florian Westphal wrote:
> From: Florian Westphal <fwestphal@astaro.com>
>
> This will cause trouble once CONFIG_COMPAT support is added
> to ebtables.
> xt_compat_*_offset() calculate the kernel/userland structure size delta
> using:
>
> XT_ALIGN(size) - COMPAT_XT_ALIGN(size)
>
> If the match/target sizes are aligned at registration time,
> delta is always zero.
>
> Should have zero effect for existing systems: xtables uses
> XT_ALIGN() whenever it deals with match/target sizes.
Applied, thanks.
next prev parent reply other threads:[~2010-02-15 17:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 14:12 [PATCH v2 0/10] netfilter: ebtables: CONFIG_COMPAT support Florian Westphal
2010-02-11 14:12 ` [PATCH 01/10] netfilter: ebtables: abort if next_offset is too small Florian Westphal
2010-02-15 17:40 ` Patrick McHardy
2010-02-11 14:12 ` [PATCH 02/10] netfilter: ebtables: avoid explicit XT_ALIGN() in match/targets Florian Westphal
2010-02-15 17:40 ` Patrick McHardy [this message]
2010-02-11 14:12 ` [PATCH 03/10] netfilter: CONFIG_COMPAT: allow delta to exceed 32767 Florian Westphal
2010-02-15 16:33 ` Patrick McHardy
2010-02-15 16:37 ` Florian Westphal
2010-02-15 17:08 ` Patrick McHardy
2010-02-15 17:40 ` Patrick McHardy
2010-02-11 14:12 ` [PATCH 04/10] netfilter: ebtables: split do_replace into two functions Florian Westphal
2010-02-11 14:12 ` [PATCH 05/10] netfilter: ebtables: split copy_everything_to_user " Florian Westphal
2010-02-11 14:12 ` [PATCH 06/10] netfilter: ebtables: split update_counters " Florian Westphal
2010-02-11 14:12 ` [PATCH 07/10] netfilter: ebtables: add CONFIG_COMPAT support Florian Westphal
2010-02-11 14:12 ` [PATCH 08/10] netfilter: ebtables: try native set/getsockopt handlers, too Florian Westphal
2010-02-11 17:40 ` Patrick McHardy
2010-02-11 21:50 ` Florian Westphal
2010-02-11 14:12 ` [PATCH 09/10] netfilter: ebt_limit: add CONFIG_COMPAT support Florian Westphal
2010-02-13 13:20 ` [PATCH v2 0/10] netfilter: ebtables: " Bart De Schuymer
2010-02-13 13:31 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B79871C.5000609@trash.net \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=fwestphal@astaro.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).