From: Patrick McHardy <kaber@trash.net>
To: Ramblewski David <David.Ramblewski@atosorigin.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: kernel stack trace using conntrack
Date: Thu, 18 Feb 2010 11:34:54 +0100 [thread overview]
Message-ID: <4B7D17CE.6010805@trash.net> (raw)
In-Reply-To: <7EF5DBE4C76A7B4DA655334E9F2BFD26CED7BC905D@FRSPX100.fr01.awl.atosorigin.net>
Ramblewski David wrote:
> Hi Eric,
>
> The conntrack patch works successfully.
>
>>> diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
>>> index 0ffe689..d2657aa 100644
>>> --- a/net/netfilter/nf_conntrack_netlink.c
>>> +++ b/net/netfilter/nf_conntrack_netlink.c
>>> @@ -923,7 +923,7 @@ ctnetlink_change_status(struct nf_conn *ct, const struct nlattr * const cda[])
>>> unsigned int status = ntohl(nla_get_be32(cda[CTA_STATUS]));
>>> d = ct->status ^ status;
>>>
>>> - if (d & (IPS_EXPECTED|IPS_CONFIRMED|IPS_DYING))
>>> + if (d & (IPS_EXPECTED|IPS_DYING))
>>> /* unchangeable */
>>> return -EBUSY;
>> I think that we should explicitly report if the user unsets
>> IPS_CONFIRMED. Please, don't change this.
>>
>> Apart from that, the patch seems fine to me. Thanks!
>
> Problem is we now (I mean after my patch) enter
> ctnetlink_change_status() with ct->status being null (or at least,
> IPS_CONFIRMED not set)
Pablo, please let me know whether you want me to apply this.
next prev parent reply other threads:[~2010-02-18 10:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 9:11 kernel stack trace using conntrack Ramblewski David
2010-02-16 9:51 ` Eric Dumazet
2010-02-16 10:25 ` Ramblewski David
2010-02-16 11:15 ` Eric Dumazet
2010-02-16 13:33 ` Pablo Neira Ayuso
2010-02-16 13:45 ` Eric Dumazet
2010-02-18 9:37 ` Ramblewski David
2010-02-18 10:34 ` Patrick McHardy [this message]
2010-02-18 11:02 ` Pablo Neira Ayuso
2010-02-18 11:15 ` Patrick McHardy
2010-02-18 12:18 ` Pablo Neira Ayuso
2010-02-18 12:19 ` Patrick McHardy
2010-02-19 2:18 ` Pablo Neira Ayuso
2010-02-19 12:33 ` Eric Dumazet
2010-02-19 13:25 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2010-02-11 13:18 Ramblewski David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7D17CE.6010805@trash.net \
--to=kaber@trash.net \
--cc=David.Ramblewski@atosorigin.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).