From: Randy Dunlap <randy.dunlap@oracle.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org, Netdev <netdev@vger.kernel.org>
Subject: Re: linux-next: Tree for February 18 (netfilter)
Date: Thu, 18 Feb 2010 09:17:11 -0800 [thread overview]
Message-ID: <4B7D7617.9070600@oracle.com> (raw)
In-Reply-To: <4B7D72FF.4010401@trash.net>
On 02/18/10 09:03, Patrick McHardy wrote:
> Randy Dunlap wrote:
>> On 02/18/10 01:49, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20100217:
>>>
>>> The net tree lost its build failure but gained a conflict against the kvm
>>> tree.
>>
>>
>> include/net/netfilter/nf_conntrack.h:94: error: field 'ct_general' has incomplete type
>> include/net/netfilter/nf_conntrack.h:178: error: 'const struct sk_buff' has no member named 'nfct'
>> include/net/netfilter/nf_conntrack.h:185: error: implicit declaration of function 'nf_conntrack_put'
>> include/net/netfilter/nf_conntrack.h:294: error: 'const struct sk_buff' has no member named 'nfct'
>> net/ipv4/netfilter/nf_defrag_ipv4.c:45: error: 'struct sk_buff' has no member named 'nfct'
>> net/ipv4/netfilter/nf_defrag_ipv4.c:46: error: 'struct sk_buff' has no member named 'nfct'
>>
>> CONFIG_NF_CONNTRACK is not enabled
>> but CONFIG_NF_DEFRAG_IPV4=y. It is "select"ed by
>> NETFILTER_XT_MATCH_SOCKET and NETFILTER_XT_TARGET_TPROXY,
>> both of which are enabled.
>>
>> Hm, NETFILTER_XT_MATCH_SOCKET depends on !NF_CONNTRACK || NF_CONNTRACK.
>> Maybe NETFILTER_XT_TARGET_TPROXY needs to do that also. No, that would
>> go against that config option's help text:
>
> No, the problem is use of skb->nfct without CONFIG_NF_CONNTRACK.
>
> This patch should fix it.
Nope:
In file included from /lnx/src/NEXT/linux-next-20100218/include/net/netfilter/nf_conntrack_extend.h:4,
from /lnx/src/NEXT/linux-next-20100218/include/net/netfilter/nf_conntrack_zones.h:4,
from /lnx/src/NEXT/linux-next-20100218/net/ipv4/netfilter/nf_defrag_ipv4.c:19:
/lnx/src/NEXT/linux-next-20100218/include/net/netfilter/nf_conntrack.h:94: error: field 'ct_general' has incomplete type
/lnx/src/NEXT/linux-next-20100218/include/net/netfilter/nf_conntrack.h: In function 'nf_ct_get':
/lnx/src/NEXT/linux-next-20100218/include/net/netfilter/nf_conntrack.h:178: error: 'const struct sk_buff' has no member named 'nfct'
/lnx/src/NEXT/linux-next-20100218/include/net/netfilter/nf_conntrack.h: In function 'nf_ct_put':
/lnx/src/NEXT/linux-next-20100218/include/net/netfilter/nf_conntrack.h:185: error: implicit declaration of function 'nf_conntrack_put'
/lnx/src/NEXT/linux-next-20100218/include/net/netfilter/nf_conntrack.h: In function 'nf_ct_is_untracked':
/lnx/src/NEXT/linux-next-20100218/include/net/netfilter/nf_conntrack.h:294: error: 'const struct sk_buff' has no member named 'nfct'
make[4]: *** [net/ipv4/netfilter/nf_defrag_ipv4.o] Error 1
--
~Randy
next prev parent reply other threads:[~2010-02-18 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100218204937.54a613d2.sfr@canb.auug.org.au>
2010-02-18 16:54 ` linux-next: Tree for February 18 (netfilter) Randy Dunlap
2010-02-18 17:03 ` Patrick McHardy
2010-02-18 17:17 ` Randy Dunlap [this message]
2010-02-18 17:45 ` Patrick McHardy
2010-02-18 17:50 ` Randy Dunlap
2010-02-18 18:04 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7D7617.9070600@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).