From: Patrick McHardy <kaber@trash.net>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: Shan Wei <shanwei@cn.fujitsu.com>,
YOSHIFUJI Hideaki <hideaki.yoshifuji@gmail.com>,
David Miller <davem@davemloft.net>,
Alexey Dobriyan <adobriyan@gmail.com>,
Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org
Subject: Re: [RFC PATCH net-next 0/7 v2]IPv6:netfilter: defragment
Date: Mon, 15 Mar 2010 17:27:24 +0100 [thread overview]
Message-ID: <4B9E5FEC.9010002@trash.net> (raw)
In-Reply-To: <4B9B9766.3090200@linux-ipv6.org>
YOSHIFUJI Hideaki wrote:
> (2010/03/11 18:16), Shan Wei wrote:
>>> On the other hand, I'd even say we should NOT send
>>> icmp here (at least by default) because standard routers
>>> never send such packet.
>>
>> Yes，for routers, the patch-set does not send icmp message to
>> source host. It only does on destination host with IPv6 connection
>> track enable.
>
> Please make it optional (via parameter) at least.
The ICMP messages are only sent if the packet is destined for the
local host, similar to what IPv6 defrag would do if conntrack wouldn't
be used. So this patch increases consistency, why should we make this
optional?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-15 16:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 6:39 [RFC PATCH net-next 0/7 v2]IPv6:netfilter: defragment Shan Wei
2010-03-10 17:13 ` YOSHIFUJI Hideaki
2010-03-11 9:16 ` Shan Wei
2010-03-13 13:47 ` YOSHIFUJI Hideaki
2010-03-15 16:27 ` Patrick McHardy [this message]
2010-03-23 16:28 ` YOSHIFUJI Hideaki
2010-03-23 17:16 ` Patrick McHardy
2010-03-23 18:58 ` YOSHIFUJI Hideaki
2010-03-23 20:10 ` Jozsef Kadlecsik
2010-03-25 4:20 ` YOSHIFUJI Hideaki
2010-03-25 9:23 ` Jozsef Kadlecsik
2010-03-25 14:14 ` YOSHIFUJI Hideaki
2010-03-25 10:25 ` Patrick McHardy
2010-03-25 8:38 ` Pascal Hambourg
2010-03-25 9:13 ` Shan Wei
2010-03-25 10:07 ` Jozsef Kadlecsik
2010-03-25 10:20 ` Patrick McHardy
2010-03-25 2:22 ` Shan Wei
2010-03-23 15:05 ` Patrick McHardy
2010-03-25 2:28 ` Shan Wei
2010-03-25 4:19 ` YOSHIFUJI Hideaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9E5FEC.9010002@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=hideaki.yoshifuji@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shanwei@cn.fujitsu.com \
--cc=yasuyuki.kozakai@toshiba.co.jp \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).