netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart De Schuymer <bdschuym@pandora.be>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: arptables 0.0.3-4 build fixes
Date: Tue, 16 Mar 2010 14:16:09 +0100	[thread overview]
Message-ID: <4B9F8499.1060104@pandora.be> (raw)
In-Reply-To: <alpine.LSU.2.01.1003161144290.27631@obet.zrqbmnf.qr>

Jan Engelhardt wrote:
> Hi,
> 
> 
> from my side two build patches for arptables.
> 
> (1) Do not call install with -o or -g, because it makes unprivileged 
> installs (used by build chroots) fail. Autotools does not use -o or -g 
> either, so the usage is consistent and does what was inteded when root
> is running `make install`.
> 
> (2) Fixing all the compiler warnings that turned up about printf 
> formatting and strict-aliasing.
> 

Hi,

Someone once insisted using this -o -g usage long ago and no
distributors have complained about it yet, so I'm going to leave it in
for now. Plenty of other projects do it this way too.

The warings that occur when using llu with 64-bit numbers should be
resolved with the PRIu64 macro. Could you fix that and resubmit, please?
Thanks.

cheers,
Bart


-- 
Bart De Schuymer
www.artinalgorithms.be

  reply	other threads:[~2010-03-16 13:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 10:48 arptables 0.0.3-4 build fixes Jan Engelhardt
2010-03-16 13:16 ` Bart De Schuymer [this message]
2010-03-16 15:27   ` Jan Engelhardt
2010-03-18  8:29     ` Bart De Schuymer
2010-03-18 13:00     ` Bart De Schuymer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9F8499.1060104@pandora.be \
    --to=bdschuym@pandora.be \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).