netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart De Schuymer <bdschuym@pandora.be>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: arptables 0.0.3-4 build fixes
Date: Thu, 18 Mar 2010 09:29:10 +0100	[thread overview]
Message-ID: <4BA1E456.10305@pandora.be> (raw)
In-Reply-To: <alpine.LSU.2.01.1003161617120.10927@obet.zrqbmnf.qr>

Jan Engelhardt wrote:
> On Tuesday 2010-03-16 14:16, Bart De Schuymer wrote:
>>> from my side two build patches for arptables.
>>>
>>> (1) Do not call install with -o or -g, because it makes unprivileged 
>>> installs (used by build chroots) fail. Autotools does not use -o or -g 
>>> either, so the usage is consistent and does what was inteded when root
>>> is running `make install`.
>>>
>>> (2) Fixing all the compiler warnings that turned up about printf 
>>> formatting and strict-aliasing.
>> Someone once insisted using this -o -g usage long ago and no
>> distributors have complained about it yet,
> 
> Fedora ships arptables_jf, which does not use -o,-g, thus does not have
> a problem to report.
> 
> OpenSUSE shipped arptables_jf. I moved it back to arptables
> because the jf fork is in an uncertain state.
> 

Yeah, too bad Redhat was so mysterious about this. The command line
options aren't even compatible. I wouldn't mind if arptables_jf became
the version used by all distros, but I'll maintain my own version as
long as it's used. On my laptop arptables_jf version 0.0.8 segfaults
with -L (built from sources).
I'll remove the -o -g stuff in ebtables' and arptables' Makefiles :-)

cheers,
Bart


-- 
Bart De Schuymer
www.artinalgorithms.be

  reply	other threads:[~2010-03-18  8:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 10:48 arptables 0.0.3-4 build fixes Jan Engelhardt
2010-03-16 13:16 ` Bart De Schuymer
2010-03-16 15:27   ` Jan Engelhardt
2010-03-18  8:29     ` Bart De Schuymer [this message]
2010-03-18 13:00     ` Bart De Schuymer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA1E456.10305@pandora.be \
    --to=bdschuym@pandora.be \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).