From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 5/9] netfilter: xt_recent: allow changing ip_list_[ug]id
 at runtime
Date: Tue, 23 Mar 2010 15:55:23 +0100
Message-ID: <4BA8D65B.5060700@trash.net>
References: <1269285486-22653-1-git-send-email-jengelh@medozas.de> <1269285486-22653-6-git-send-email-jengelh@medozas.de> <4BA8CDB9.1010304@trash.net> <alpine.LSU.2.01.1003231521460.21129@obet.zrqbmnf.qr>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: netfilter-devel@vger.kernel.org
To: Jan Engelhardt <jengelh@medozas.de>
Return-path: <netfilter-devel-owner@vger.kernel.org>
Received: from stinky.trash.net ([213.144.137.162]:59561 "EHLO
	stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754283Ab0CWOzZ (ORCPT
	<rfc822;netfilter-devel@vger.kernel.org>);
	Tue, 23 Mar 2010 10:55:25 -0400
In-Reply-To: <alpine.LSU.2.01.1003231521460.21129@obet.zrqbmnf.qr>
Sender: netfilter-devel-owner@vger.kernel.org
List-ID: <netfilter-devel.vger.kernel.org>

Jan Engelhardt wrote:
> On Tuesday 2010-03-23 15:18, Patrick McHardy wrote:
>   
>>>  module_param(ip_list_perms, uint, 0400);
>>> -module_param(ip_list_uid, uint, 0400);
>>> -module_param(ip_list_gid, uint, 0400);
>>> +module_param(ip_list_uid, uint, S_IRUGO | S_IWUSR);
>>> +module_param(ip_list_gid, uint, S_IRUGO | S_IWUSR);
>>>  MODULE_PARM_DESC(ip_list_tot, "number of IPs to remember per list");
>>>  MODULE_PARM_DESC(ip_pkt_list_tot, "number of packets per IP address to remember (max. 255)");
>>>  MODULE_PARM_DESC(ip_list_hash_size, "size of hash table used to look up IPs");
>>>  MODULE_PARM_DESC(ip_list_perms, "permissions on /proc/net/xt_recent/* files");
>>> -MODULE_PARM_DESC(ip_list_uid,"owner of /proc/net/xt_recent/* files");
>>> -MODULE_PARM_DESC(ip_list_gid,"owning group of /proc/net/xt_recent/* files");
>>> +MODULE_PARM_DESC(ip_list_uid, "default owner of /proc/net/xt_recent/* files");
>>> +MODULE_PARM_DESC(ip_list_gid, "default owning group of /proc/net/xt_recent/* files");
>>>       
>> So what will be updating the permissions of the existing proc files?
>>     
>
> The administrator with the use of chmod/chown/chgrp.
>   
I'm not sure whether this will have the desired effect. I vaguely recall
that
proc used to forget about permission changes. That might have been
fixed, but
I was unable to find something in the changelogs.