netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Jan Engelhardt <jengelh@medozas.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 4/4] netfilter: xtables: schedule xt_state for removal
Date: Thu, 25 Mar 2010 13:49:39 +0100	[thread overview]
Message-ID: <4BAB5BE3.3020703@trash.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1003251339180.22672@blackhole.kfki.hu>

Jozsef Kadlecsik wrote:
> On Thu, 25 Mar 2010, Jan Engelhardt wrote:
> 
>>>>> and it seems more intuitive to write "-m state"
>>>>> than "-m conntrack --ctstate" to me.
>>>> I oppose the removal of xt_state, *unless* the userspace "-m state" is 
>>>> kept working and the conntrack module automatically supports it.
>>> Yes, that would be acceptable.
>>>
>>>> It's such a basic match that it's simply overkill to remove it.
>>> Agreed.
>> So what now? Should xt_conntrack be perhaps rebranded as a new
>> xt_state rev and let's obsolete xt_conntrack.c instead?
> 
> That's much more acceptable, also because of the usage patterns. And the 
> migration can be made easier with module aliasing.

Yes, I prefer that way as well. Both state and conntrack should
continue to work in userspace.

  reply	other threads:[~2010-03-25 12:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23 20:44 nf-next: removals of old extensions/revs Jan Engelhardt
2010-03-23 20:44 ` [PATCH 1/4] netfilter: xtables: remove xt_hashlimit revision 0 Jan Engelhardt
2010-03-23 20:44 ` [PATCH 2/4] netfilter: xtables: remove xt_multiport " Jan Engelhardt
2010-03-23 20:44 ` [PATCH 3/4] netfilter: xtables: remove xt_string " Jan Engelhardt
2010-03-23 20:45 ` [PATCH 4/4] netfilter: xtables: schedule xt_state for removal Jan Engelhardt
2010-03-24 15:02   ` Patrick McHardy
2010-03-24 15:22     ` Jan Engelhardt
2010-03-25 10:06       ` Patrick McHardy
2010-03-25 10:17         ` Jozsef Kadlecsik
2010-03-25 10:26           ` Patrick McHardy
2010-03-25 12:38             ` Jan Engelhardt
2010-03-25 12:43               ` Jozsef Kadlecsik
2010-03-25 12:49                 ` Patrick McHardy [this message]
2010-03-25 16:09                   ` Jan Engelhardt
2010-03-25 18:51                 ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BAB5BE3.3020703@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@medozas.de \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).