From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/5] netfilter: xt extensions: use pr_<level> (2)
Date: Thu, 25 Mar 2010 14:59:43 +0100 [thread overview]
Message-ID: <4BAB6C4F.9040002@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.01.1003251443530.32573@obet.zrqbmnf.qr>
Jan Engelhardt wrote:
> On Thursday 2010-03-25 14:27, Patrick McHardy wrote:
>> Fair enough, but some consistency among modules would be great. There
>> are a few instances of pr_err/warning used for memory allocation errors
>> or invalid parameters in this patch.
>
> As far as I can see, I've been consistent.
>
> pcregrep -r 'pr_(?!info)' net/ipv4/netfilter/ net/ipv6/netfilter/
> net/bridge/netfilter/ net/netfilter/ | grep -v pr_debug |
> grep -v pr_fmt | less
>
> Only shows either lines outside .checkentry, or things that really
> are an error, such as xt_LED.c being unable to register its ledtrigger,
> which is not a "user parameter error" and thus would not be pr_info.
>
> If you see inconsistency, could you hint me towards it?
Right, I didn't notice these were all outside of checkentry.
next prev parent reply other threads:[~2010-03-25 13:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 12:56 nf-next: cleanups (rd.3) Jan Engelhardt
2010-03-25 12:56 ` [PATCH 1/5] netfilter: xtables: make use of caller family rather than target family Jan Engelhardt
2010-03-25 12:56 ` [PATCH 2/5] netfilter: xt extensions: use pr_<level> (2) Jan Engelhardt
2010-03-25 13:08 ` Patrick McHardy
2010-03-25 13:20 ` Jan Engelhardt
2010-03-25 13:27 ` Patrick McHardy
2010-03-25 13:52 ` Jan Engelhardt
2010-03-25 13:59 ` Jan Engelhardt
2010-03-25 13:59 ` Patrick McHardy [this message]
2010-03-25 14:03 ` Jan Engelhardt
2010-03-25 14:10 ` Patrick McHardy
2010-03-25 14:10 ` Bart De Schuymer
2010-03-25 14:11 ` Jan Engelhardt
2010-03-25 12:56 ` [PATCH 3/5] netfilter: xtables: make use of xt_request_find_target Jan Engelhardt
2010-03-25 12:56 ` [PATCH 4/5] netfilter: xtables: consolidate code into xt_request_find_match Jan Engelhardt
2010-03-25 13:09 ` Patrick McHardy
2010-03-25 12:56 ` [PATCH 5/5] netfilter: xt_recent: allow changing ip_list_[ug]id at runtime Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAB6C4F.9040002@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).