Re: [PATCH] Add refcounts to LED target

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Thursday 2010-03-25 15:01, Patrick McHardy wrote:
>> Patrick McHardy wrote:
>>> Adam Nielsen wrote:
>>>>> Since this has already taken ages, I took the liberty of preparing
>>>>> an example fix. Adam, please have a look at this and give it some
>>>>> testing.
>>>> Well I'm afraid I can't see why, but for some reason once I add a second
>>>> iptables rule with this target my kernel often locks up, hard (audio
>>>> starts skipping, magic SysRq keys don't work) even if I don't have any
>>>> actual LED devices on the system.  The first rule, even when attached to
>>>> a LED device, seems to work fine.
>>>>
>>>> I'll have to do some more debugging to see if I can figure out where
>>>> it's locking up.
>>> Its probably the timer, which uses the ledinfo of the first rule as
>>> private data. Try passing ledinternal to the timer instead of ledinfo,
>>> that should fix it.
>> I've waited patiently for about a year for this simple problem to
>> get fixed. Unless I see a patch in time for 2.6.34, I'll remove
>> the LED module again.
> 
> I want to give this a look, but I notice there's no iptables module
> files for xt_LED yet either.

Correct, I didn't add it while this was still unfixed to keep
the possibility of removing the module again. You should be able
to find it in the mailing list archives.