From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 4/4] netfilter: xtables: merge registration structure to NFPROTO_UNSPEC Date: Wed, 31 Mar 2010 10:41:04 +0200 Message-ID: <4BB30AA0.9000904@trash.net> References: <1270022629-2494-1-git-send-email-jengelh@medozas.de> <1270022629-2494-5-git-send-email-jengelh@medozas.de> <4BB30861.3060101@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:57217 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932704Ab0CaIlF (ORCPT ); Wed, 31 Mar 2010 04:41:05 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jan Engelhardt wrote: > On Wednesday 2010-03-31 10:31, Patrick McHardy wrote: >> Jan Engelhardt wrote: >>> +static struct xt_match state_mt_reg __read_mostly = { >>> + .name = "state", >>> + .family = NFPROTO_UNSPEC, >>> + .checkentry = state_mt_check, >>> + .match = state_mt, >>> + .destroy = state_mt_destroy, >>> + .matchsize = sizeof(struct xt_state_info), >>> + .me = THIS_MODULE, >>> }; >> This is the one I actually wanted to see since the subject didn't >> state which module is changes. >> >> The patch looks fine, however I'd prefer if in the future you'd add >> a changelog entry for these conversions stating why this will work >> properly in all cases even with arptables and ebtables using the >> xtables infrastructure. > > This will work because x_tables scans for NFPROTO_UNSPEC, > and arp/ebtables just using x_tables :-) I'm not sure I'm parsing this correctly. Both will find the match, however the nf_ct_l3proto_try_module_get() call will fail, so they can't actually use this (which is correct). Anyways, this should be stated in the changelog.