From: Patrick McHardy <kaber@trash.net>
To: Adam Nielsen <a.nielsen@shikadi.net>
Cc: Jan Engelhardt <jengelh@medozas.de>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH v3] Add refcounts to LED target
Date: Thu, 08 Apr 2010 13:33:29 +0200 [thread overview]
Message-ID: <4BBDBF09.6070403@trash.net> (raw)
In-Reply-To: <4BBD478F.4050208@shikadi.net>
Adam Nielsen wrote:
>>> I also noticed one another thing: you don't increase the refcount while
>>> xt_led_mutex is held. That means it is theoretically possible that you
>>> do a lookup, then a destructor runs and frees the object, leading to
>>> ++ledinternal->refcnt dereference an illegal ledinternal.
>
> Thanks both for your comments and explanations. I've attached an updated
> patch, I hope this one addresses these issues.
>
>> Indeed, I also noticed this. Basically, you need to make sure that
>>
>> - the lookup and refcnt increase is atomic,
>> - the refcnt decrease and list deletion is atomic
>> - the lookup and list insertion is atomic (in case no trigger exists)
>
> I've moved the mutex around so that hopefully all these operations are now atomic.
>
>> The remaining parts look fine to me, thanks.
>
> Great, I hope you're happy with this one!
Looks good to me, thanks. Jan, any further issues from your side?
Otherwise I'll apply it.
next prev parent reply other threads:[~2010-04-08 11:33 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 1:46 Avoiding multiple calls to xt_target.checkentry Adam Nielsen
2009-05-24 7:34 ` Jan Engelhardt
2009-05-27 23:07 ` Adam Nielsen
2009-05-28 21:06 ` Jan Engelhardt
2009-06-03 9:25 ` Patrick McHardy
2009-06-03 11:03 ` Adam Nielsen
2009-11-05 15:00 ` Patrick McHardy
2009-11-05 18:40 ` Jan Engelhardt
2009-11-05 18:43 ` Patrick McHardy
2009-11-05 22:04 ` Adam Nielsen
2009-11-06 14:56 ` Patrick McHardy
2009-11-29 1:43 ` [PATCH] Add refcounts to LED target Adam Nielsen
2009-11-29 10:12 ` Jan Engelhardt
2009-11-29 11:33 ` Adam Nielsen
2009-11-29 15:49 ` Jan Engelhardt
2009-12-01 10:05 ` Patrick McHardy
2009-12-06 10:09 ` Adam Nielsen
2009-12-06 13:24 ` Patrick McHardy
2010-03-25 14:01 ` Patrick McHardy
2010-03-25 14:05 ` Jan Engelhardt
2010-03-25 14:08 ` Patrick McHardy
2010-03-27 4:05 ` Adam Nielsen
2010-03-27 11:15 ` Jan Engelhardt
2010-03-27 11:39 ` Adam Nielsen
2010-03-27 11:55 ` Jan Engelhardt
2010-03-28 1:25 ` [PATCH v2] " Adam Nielsen
2010-04-04 11:30 ` Jan Engelhardt
2010-04-07 16:15 ` Patrick McHardy
2010-04-08 3:03 ` [PATCH v3] " Adam Nielsen
2010-04-08 11:33 ` Patrick McHardy [this message]
2010-04-08 12:45 ` Jan Engelhardt
2010-04-08 12:57 ` Patrick McHardy
2010-04-08 23:06 ` [PATCH v4] " Adam Nielsen
2010-04-09 14:52 ` Patrick McHardy
2010-04-08 21:07 ` [PATCH v3] " Florian Westphal
2010-04-08 22:45 ` Adam Nielsen
2010-03-27 18:42 ` [PATCH] " Jan Engelhardt
2010-03-28 1:58 ` Adam Nielsen
2010-04-04 11:59 ` Jan Engelhardt
2010-04-08 3:15 ` input-layer LEDs as LED-class devices (was: Add refcounts to LED target) Adam Nielsen
2010-04-08 8:03 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBDBF09.6070403@trash.net \
--to=kaber@trash.net \
--cc=a.nielsen@shikadi.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).