From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH 4/6] netfilter: xtables2: make ip_tables reentrant
Date: Tue, 13 Apr 2010 11:57:29 +0200 [thread overview]
Message-ID: <4BC44009.4080206@trash.net> (raw)
In-Reply-To: <1270666217-27670-5-git-send-email-jengelh@medozas.de>
Jan Engelhardt wrote:
> diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
> index 8e23d8f..2010b56 100644
> --- a/net/netfilter/x_tables.c
> +++ b/net/netfilter/x_tables.c
> @@ -62,6 +62,11 @@ static const char *const xt_prefix[NFPROTO_NUMPROTO] = {
> [NFPROTO_IPV6] = "ip6",
> };
>
> +/* Allow this many total (re)entries. */
> +static unsigned int xt_jumpstack_multiplier = 2;
> +module_param_named(jumpstack_multiplier, xt_jumpstack_multiplier,
> + uint, S_IRUGO | S_IWUSR);
> +
This seems very wrong. Why should the user care about this?
I still don't like this patch very much, its only used for a very
special case and I'm not convinced that reentrancy of TEE'ed packets
is enough justification for this. Perhaps actually getting rid of
the per-cpu copies of the ruleset could convince me :)
next prev parent reply other threads:[~2010-04-13 9:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 18:50 nf-next: TEE/reentrancy 20100407 Jan Engelhardt
2010-04-07 18:50 ` [PATCH 1/6] netfilter: ipv6: move POSTROUTING invocation before fragmentation Jan Engelhardt
2010-04-07 18:50 ` [PATCH 2/6] netfilter: ipv6: add IPSKB_REROUTED exclusion to NF_HOOK/POSTROUTING invocation Jan Engelhardt
2010-04-07 18:50 ` [PATCH 3/6] netfilter: xtables: inclusion of xt_TEE Jan Engelhardt
2010-04-07 18:50 ` [PATCH 4/6] netfilter: xtables2: make ip_tables reentrant Jan Engelhardt
2010-04-13 9:57 ` Patrick McHardy [this message]
2010-04-13 10:50 ` Jan Engelhardt
2010-04-13 10:51 ` Patrick McHardy
2010-04-13 11:12 ` Jan Engelhardt
2010-04-13 11:15 ` Patrick McHardy
2010-04-13 11:42 ` Jan Engelhardt
2010-04-13 12:29 ` Patrick McHardy
2010-04-07 18:50 ` [PATCH 5/6] netfilter: xt_TEE: have cloned packet travel through Xtables too Jan Engelhardt
2010-04-13 10:00 ` Patrick McHardy
2010-04-13 10:51 ` Jan Engelhardt
2010-04-13 10:53 ` Patrick McHardy
2010-04-13 12:38 ` Eric Dumazet
2010-04-07 18:50 ` [PATCH 6/6] netfilter: xtables: remove old comments about reentrancy Jan Engelhardt
2010-04-09 9:39 ` nf-next: TEE/reentrancy 20100407 Jan Engelhardt
2010-04-09 14:53 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC44009.4080206@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).