From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH 5/6] netfilter: xt_TEE: have cloned packet travel through Xtables too
Date: Tue, 13 Apr 2010 12:53:59 +0200 [thread overview]
Message-ID: <4BC44D47.1080404@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.01.1004131250220.11306@obet.zrqbmnf.qr>
Jan Engelhardt wrote:
> On Tuesday 2010-04-13 12:00, Patrick McHardy wrote:
>> Jan Engelhardt wrote:
>>> --- a/net/netfilter/xt_TEE.c
>>> +++ b/net/netfilter/xt_TEE.c
>>> @@ -33,6 +33,7 @@ static struct nf_conn tee_track;
>>> #endif
>>>
>>> static const union nf_inet_addr tee_zero_address;
>>> +static bool tee_active[NR_CPUS];
>> DEFINE_PER_CPU?
>
> I asked about that. It seems like percpu.h puts the variable in an extra
> section and with pretty much #define magic around it (e.g. look at the
> #definition of percpu_set) all of which did not seem necessary to me.
>
It should avoid having a huge array that bounces between CPUs
since their entries are located next to each other.
next prev parent reply other threads:[~2010-04-13 10:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 18:50 nf-next: TEE/reentrancy 20100407 Jan Engelhardt
2010-04-07 18:50 ` [PATCH 1/6] netfilter: ipv6: move POSTROUTING invocation before fragmentation Jan Engelhardt
2010-04-07 18:50 ` [PATCH 2/6] netfilter: ipv6: add IPSKB_REROUTED exclusion to NF_HOOK/POSTROUTING invocation Jan Engelhardt
2010-04-07 18:50 ` [PATCH 3/6] netfilter: xtables: inclusion of xt_TEE Jan Engelhardt
2010-04-07 18:50 ` [PATCH 4/6] netfilter: xtables2: make ip_tables reentrant Jan Engelhardt
2010-04-13 9:57 ` Patrick McHardy
2010-04-13 10:50 ` Jan Engelhardt
2010-04-13 10:51 ` Patrick McHardy
2010-04-13 11:12 ` Jan Engelhardt
2010-04-13 11:15 ` Patrick McHardy
2010-04-13 11:42 ` Jan Engelhardt
2010-04-13 12:29 ` Patrick McHardy
2010-04-07 18:50 ` [PATCH 5/6] netfilter: xt_TEE: have cloned packet travel through Xtables too Jan Engelhardt
2010-04-13 10:00 ` Patrick McHardy
2010-04-13 10:51 ` Jan Engelhardt
2010-04-13 10:53 ` Patrick McHardy [this message]
2010-04-13 12:38 ` Eric Dumazet
2010-04-07 18:50 ` [PATCH 6/6] netfilter: xtables: remove old comments about reentrancy Jan Engelhardt
2010-04-09 9:39 ` nf-next: TEE/reentrancy 20100407 Jan Engelhardt
2010-04-09 14:53 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC44D47.1080404@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).