From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH 4/6] netfilter: xtables2: make ip_tables reentrant
Date: Tue, 13 Apr 2010 13:15:38 +0200 [thread overview]
Message-ID: <4BC4525A.8000507@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.01.1004131311330.16098@obet.zrqbmnf.qr>
Jan Engelhardt wrote:
> On Tuesday 2010-04-13 12:51, Patrick McHardy wrote:
>>>>> +/* Allow this many total (re)entries. */
>>>>> +static unsigned int xt_jumpstack_multiplier = 2;
>>>>> +module_param_named(jumpstack_multiplier, xt_jumpstack_multiplier,
>>>>> + uint, S_IRUGO | S_IWUSR);
>>>>> +
>>>> This seems very wrong. Why should the user care about this?
>>> Who said every sysfs variable is for end-users?
>> Then who should care?
>
> Developers, perhaps. Not exporting the parameter is no big deal.
Developers can change it in the source code. Please remove the
parameter and hard code it.
I'll then apply this patch if we can get rid of the ruleset
duplication for each CPU.
next prev parent reply other threads:[~2010-04-13 11:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 18:50 nf-next: TEE/reentrancy 20100407 Jan Engelhardt
2010-04-07 18:50 ` [PATCH 1/6] netfilter: ipv6: move POSTROUTING invocation before fragmentation Jan Engelhardt
2010-04-07 18:50 ` [PATCH 2/6] netfilter: ipv6: add IPSKB_REROUTED exclusion to NF_HOOK/POSTROUTING invocation Jan Engelhardt
2010-04-07 18:50 ` [PATCH 3/6] netfilter: xtables: inclusion of xt_TEE Jan Engelhardt
2010-04-07 18:50 ` [PATCH 4/6] netfilter: xtables2: make ip_tables reentrant Jan Engelhardt
2010-04-13 9:57 ` Patrick McHardy
2010-04-13 10:50 ` Jan Engelhardt
2010-04-13 10:51 ` Patrick McHardy
2010-04-13 11:12 ` Jan Engelhardt
2010-04-13 11:15 ` Patrick McHardy [this message]
2010-04-13 11:42 ` Jan Engelhardt
2010-04-13 12:29 ` Patrick McHardy
2010-04-07 18:50 ` [PATCH 5/6] netfilter: xt_TEE: have cloned packet travel through Xtables too Jan Engelhardt
2010-04-13 10:00 ` Patrick McHardy
2010-04-13 10:51 ` Jan Engelhardt
2010-04-13 10:53 ` Patrick McHardy
2010-04-13 12:38 ` Eric Dumazet
2010-04-07 18:50 ` [PATCH 6/6] netfilter: xtables: remove old comments about reentrancy Jan Engelhardt
2010-04-09 9:39 ` nf-next: TEE/reentrancy 20100407 Jan Engelhardt
2010-04-09 14:53 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC4525A.8000507@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).