From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/8] netfilter: xtables: inclusion of xt_TEE
Date: Tue, 13 Apr 2010 15:45:15 +0200 [thread overview]
Message-ID: <4BC4756B.4090307@trash.net> (raw)
In-Reply-To: <1271162268-28131-4-git-send-email-jengelh@medozas.de>
Jan Engelhardt wrote:
> +static bool
> +tee_tg_route4(struct sk_buff *skb, const struct xt_tee_tginfo *info)
> +{
> + const struct iphdr *iph = ip_hdr(skb);
> + struct rtable *rt;
> + struct flowi fl;
> +
> + memset(&fl, 0, sizeof(fl));
> + fl.nl_u.ip4_u.daddr = info->gw.ip;
> + fl.nl_u.ip4_u.tos = RT_TOS(iph->tos);
> + fl.nl_u.ip4_u.scope = RT_SCOPE_UNIVERSE;
> +
> + if (ip_route_output_key(dev_net(skb->dev), &rt, &fl) != 0) {
You can't use skb->dev in modules that are valid to use in LOCAL_OUT.
> +#ifdef WITH_CONNTRACK
> + nf_conntrack_put(skb->nfct);
> + skb->nfct = &tee_track.ct_general;
> + skb->nfctinfo = IP_CT_NEW;
> + nf_conntrack_get(skb->nfct);
> +#endif
Why do we still need this? I thought the reentrancy-counter should take
care of this?
next prev parent reply other threads:[~2010-04-13 13:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 12:37 nf-next: reentrancy, new modules Jan Engelhardt
2010-04-13 12:37 ` [PATCH 1/8] netfilter: ipv6: move POSTROUTING invocation before fragmentation Jan Engelhardt
2010-04-13 13:30 ` Patrick McHardy
2010-04-13 12:37 ` [PATCH 2/8] netfilter: ipv6: add IPSKB_REROUTED exclusion to NF_HOOK/POSTROUTING invocation Jan Engelhardt
2010-04-13 13:33 ` Patrick McHardy
2010-04-13 13:34 ` Jan Engelhardt
2010-04-13 13:36 ` Patrick McHardy
2010-04-13 12:37 ` [PATCH 3/8] netfilter: xtables: inclusion of xt_TEE Jan Engelhardt
2010-04-13 13:37 ` Patrick McHardy
2010-04-13 13:45 ` Patrick McHardy [this message]
2010-04-13 16:09 ` Jan Engelhardt
2010-04-13 16:17 ` Jan Engelhardt
2010-04-13 16:33 ` Patrick McHardy
2010-04-13 16:32 ` Patrick McHardy
2010-04-13 17:28 ` Jan Engelhardt
2010-04-13 17:31 ` Patrick McHardy
2010-04-13 12:37 ` [PATCH 4/8] netfilter: xtables2: make ip_tables reentrant Jan Engelhardt
2010-04-13 12:37 ` [PATCH 5/8] netfilter: xt_TEE: have cloned packet travel through Xtables too Jan Engelhardt
2010-04-13 12:37 ` [PATCH 6/8] netfilter: xtables: remove old comments about reentrancy Jan Engelhardt
2010-04-13 12:37 ` [PATCH 7/8] netfilter: xtables: inclusion of xt_SYSRQ Jan Engelhardt
2010-04-13 12:37 ` [PATCH 8/8] netfilter: xtables: inclusion of xt_condition Jan Engelhardt
2010-04-13 13:26 ` nf-next: reentrancy, new modules Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC4756B.4090307@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).