From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/4] netfilter: xtables: inclusion of xt_TEE
Date: Wed, 14 Apr 2010 12:56:35 +0200 [thread overview]
Message-ID: <4BC59F63.2060803@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.01.1004141159390.9499@obet.zrqbmnf.qr>
Jan Engelhardt wrote:
> On Wednesday 2010-04-14 07:52, Eric Dumazet wrote:
>>> +#ifdef WITH_CONNTRACK
>>> + /* Avoid counting cloned packets towards the original connection. */
>>> + nf_conntrack_put(skb->nfct);
>>> + skb->nfct = &nf_conntrack_untracked.ct_general;
>>> + skb->nfctinfo = IP_CT_NEW;
>>> + nf_conntrack_get(skb->nfct);
>> This atomic increment on a global variable worries me... Would it be
>> possible to avoid it (and the associated decrement and test if null)
>>
>> I would like to use this TEE facility but with xxx kpps for instance ;)
>
> Correctness before speed. You're free to send patches on top.
>
Pablo suggest to encode "untracked" in one of the nfctinfo bits a
while ago, which would avoid all atomic operations. Anyways, this
can be done later.
next prev parent reply other threads:[~2010-04-14 10:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 23:21 nf-next: TEE only Jan Engelhardt
2010-04-13 23:21 ` [PATCH 1/4] netfilter: xtables: inclusion of xt_TEE Jan Engelhardt
2010-04-14 5:52 ` Eric Dumazet
2010-04-14 10:00 ` Jan Engelhardt
2010-04-14 10:56 ` Patrick McHardy [this message]
2010-04-13 23:21 ` [PATCH 2/4] netfilter: xtables2: make ip_tables reentrant Jan Engelhardt
2010-04-13 23:21 ` [PATCH 3/4] netfilter: xt_TEE: have cloned packet travel through Xtables too Jan Engelhardt
2010-04-13 23:21 ` [PATCH 4/4] netfilter: xtables: remove old comments about reentrancy Jan Engelhardt
2010-04-14 10:57 ` nf-next: TEE only Patrick McHardy
2010-04-14 11:15 ` Jan Engelhardt
2010-04-14 11:24 ` Patrick McHardy
2010-04-14 11:32 ` Jan Engelhardt
2010-04-15 11:41 ` Jan Engelhardt
2010-04-15 11:56 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2010-04-15 23:25 nf-next: TEE 20100215 Jan Engelhardt
2010-04-15 23:25 ` [PATCH 1/4] netfilter: xtables: inclusion of xt_TEE Jan Engelhardt
2010-04-19 12:20 ` Patrick McHardy
2010-04-19 12:36 ` Jan Engelhardt
2010-04-19 12:42 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC59F63.2060803@trash.net \
--to=kaber@trash.net \
--cc=eric.dumazet@gmail.com \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).