From: Patrick McHardy <kaber@trash.net>
To: Karl Hiramoto <karl@hiramoto.org>
Cc: Jan Engelhardt <jengelh@medozas.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: optionally disable largefile support.
Date: Mon, 10 May 2010 17:25:06 +0200 [thread overview]
Message-ID: <4BE82552.1080705@trash.net> (raw)
In-Reply-To: <4BE7C063.5000302@hiramoto.org>
Karl Hiramoto wrote:
> On 05/10/2010 10:00 AM, Jan Engelhardt wrote:
>> What is the actual problem you are experiencing? If the toolchain does
>> not support largefiles, the -D macros should not do anything, so that
>> conversely, their presence is not harmful.
>>
> Uclibc include headers do checking see:
>
> http://git.uclibc.org/uClibc/tree/include/features.h#n216
>
>
> You get errors like:
>
>
> usr/include/features.h:383:4: error: #error It appears you have defined
> _FILE_OFFSET_BITS=64. Unfortunately, uClibc was built without large file
> support enabled.
> In file included from /build_armeb/staging_dir/usr/include/stdio.h:72,
> from libiptc/libip4tc.c:18:
> /build_armeb/staging_dir/usr/include/bits/uClibc_stdio.h:72:2: error:
> #error Sorry... uClibc was built without large file support!
> In file included from libiptc/libip4tc.c:18:
> /build_armeb/staging_dir/usr/include/stdio.h:83: error: expected '=',
> ',', ';', 'asm' or '__attribute__' before 'fpos_t'
> In file included from libiptc/libip4tc.c:18:
> /build_armeb/staging_dir/usr/include/stdio.h:709: error: expected
> declaration specifiers or '...' before 'fpos_t'
> /build_armeb/staging_dir/usr/include/stdio.h:711: error: expected ';',
> ',' or ')' before '*' token
>
>
> With this patch everything compiles and works fine.
Thanks for the explanation. Jan, can I assume you're OK with this patch?
next prev parent reply other threads:[~2010-05-10 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 7:30 [PATCH] iptables: optionally disable largefile support Karl Hiramoto
2010-05-10 8:00 ` Jan Engelhardt
2010-05-10 8:14 ` Karl Hiramoto
2010-05-10 15:25 ` Patrick McHardy [this message]
2010-05-10 15:48 ` Jan Engelhardt
2010-05-10 15:52 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE82552.1080705@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=karl@hiramoto.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).