From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] iptables: optionally disable largefile support. Date: Mon, 10 May 2010 17:25:06 +0200 Message-ID: <4BE82552.1080705@trash.net> References: <1273476638-31417-1-git-send-email-karl@hiramoto.org> <4BE7C063.5000302@hiramoto.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Jan Engelhardt , netfilter-devel@vger.kernel.org To: Karl Hiramoto Return-path: Received: from stinky.trash.net ([213.144.137.162]:48362 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041Ab0EJPZH (ORCPT ); Mon, 10 May 2010 11:25:07 -0400 In-Reply-To: <4BE7C063.5000302@hiramoto.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Karl Hiramoto wrote: > On 05/10/2010 10:00 AM, Jan Engelhardt wrote: >> What is the actual problem you are experiencing? If the toolchain does >> not support largefiles, the -D macros should not do anything, so that >> conversely, their presence is not harmful. >> > Uclibc include headers do checking see: > > http://git.uclibc.org/uClibc/tree/include/features.h#n216 > > > You get errors like: > > > usr/include/features.h:383:4: error: #error It appears you have defined > _FILE_OFFSET_BITS=64. Unfortunately, uClibc was built without large file > support enabled. > In file included from /build_armeb/staging_dir/usr/include/stdio.h:72, > from libiptc/libip4tc.c:18: > /build_armeb/staging_dir/usr/include/bits/uClibc_stdio.h:72:2: error: > #error Sorry... uClibc was built without large file support! > In file included from libiptc/libip4tc.c:18: > /build_armeb/staging_dir/usr/include/stdio.h:83: error: expected '=', > ',', ';', 'asm' or '__attribute__' before 'fpos_t' > In file included from libiptc/libip4tc.c:18: > /build_armeb/staging_dir/usr/include/stdio.h:709: error: expected > declaration specifiers or '...' before 'fpos_t' > /build_armeb/staging_dir/usr/include/stdio.h:711: error: expected ';', > ',' or ')' before '*' token > > > With this patch everything compiles and works fine. Thanks for the explanation. Jan, can I assume you're OK with this patch?