From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Tobias Doerffel <tobias.doerffel@gmail.com>,
netfilter-devel@vger.kernel.org,
Krzysztof Piotr Oledzki <ole@ans.pl>
Subject: Re: [PATCH] netfilter: scheduled removal of CONFIG_NF_CT_ACCT
Date: Mon, 31 May 2010 17:56:03 +0200 [thread overview]
Message-ID: <4C03DC13.9080307@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.01.1005311751330.9888@obet.zrqbmnf.qr>
Jan Engelhardt wrote:
> On Monday 2010-05-31 17:24, Patrick McHardy wrote:
>> Tobias Doerffel wrote:
>>> Removal of the CONFIG_NF_CT_ACCT was already scheduled for 2.6.29,
>>> therefore remove it now and set nf_conntrack.acct depending on
>>> CONFIG_NETFILTER_XT_MATCH_CONNBYTES.
>> This has already been discussed multiple times. The connbytes
>> match needs accounting, so it needs to enable it when the first
>> rule containing a connbytes match is added. This needs to be
>> done in the namespace where the rule is added.
>
> If it is done as late as rule insertion, connbytes might match (or
> not - and thus be a problem) when there are still CTs around without
> a counter tuple. Hm.
Yeah, we also discussed that part, but we can't do any better.
The alternative for people is to manually enable it when loading
conntrack.
prev parent reply other threads:[~2010-05-31 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 11:51 [PATCH] netfilter: scheduled removal of CONFIG_NF_CT_ACCT Tobias Doerffel
2010-05-31 15:24 ` Patrick McHardy
2010-05-31 15:52 ` Jan Engelhardt
2010-05-31 15:56 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C03DC13.9080307@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=ole@ans.pl \
--cc=tobias.doerffel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).