From: Patrick McHardy <kaber@trash.net>
To: Dan Carpenter <error27@gmail.com>
Cc: ebtables-devel@lists.sourceforge.net, netfilter-devel@vger.kernel.org
Subject: Re: [rfc] netfilter: copy less data to the user
Date: Thu, 15 Jul 2010 11:48:09 +0200 [thread overview]
Message-ID: <4C3ED959.4080007@trash.net> (raw)
In-Reply-To: <20100714210430.GB5164@bicker>
Am 14.07.2010 23:04, schrieb Dan Carpenter:
> Smatch complains that we copy too much data to the user in ebtables.
> We copied EBT_FUNCTION_MAXNAMELEN (32) characters to the user here, but
> "m->u.match->name" has XT_EXTENSION_MAXNAMELEN (29) characters.
>
> I'm not sure if this is a bug where someone got confused with m->u.name
> which has 32 characters or if this is done for backwards compatability.
Looking at ebtables.h, ebt_entry_match->name uses
EBT_FUNCTION_MAXNAMELEN, which is 32 bytes. Where did you get
XT_EXTENSION_MAXNAMELEN from?
>
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index 59ca00e..6bcb31d 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -1323,7 +1323,7 @@ static inline int ebt_make_matchname(const struct ebt_entry_match *m,
> const char *base, char __user *ubase)
> {
> char __user *hlp = ubase + ((char *)m - base);
> - if (copy_to_user(hlp, m->u.match->name, EBT_FUNCTION_MAXNAMELEN))
> + if (copy_to_user(hlp, m->u.match->name, XT_EXTENSION_MAXNAMELEN))
> return -EFAULT;
> return 0;
> }
> @@ -1332,7 +1332,7 @@ static inline int ebt_make_watchername(const struct ebt_entry_watcher *w,
> const char *base, char __user *ubase)
> {
> char __user *hlp = ubase + ((char *)w - base);
> - if (copy_to_user(hlp , w->u.watcher->name, EBT_FUNCTION_MAXNAMELEN))
> + if (copy_to_user(hlp , w->u.watcher->name, XT_EXTENSION_MAXNAMELEN))
> return -EFAULT;
> return 0;
> }
> @@ -1356,7 +1356,7 @@ ebt_make_names(struct ebt_entry *e, const char *base, char __user *ubase)
> ret = EBT_WATCHER_ITERATE(e, ebt_make_watchername, base, ubase);
> if (ret != 0)
> return ret;
> - if (copy_to_user(hlp, t->u.target->name, EBT_FUNCTION_MAXNAMELEN))
> + if (copy_to_user(hlp, t->u.target->name, XT_EXTENSION_MAXNAMELEN))
> return -EFAULT;
> return 0;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-07-15 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 21:04 [rfc] netfilter: copy less data to the user Dan Carpenter
2010-07-15 9:48 ` Patrick McHardy [this message]
2010-07-15 10:16 ` Dan Carpenter
2010-07-15 15:29 ` Patrick McHardy
2010-07-25 16:36 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3ED959.4080007@trash.net \
--to=kaber@trash.net \
--cc=ebtables-devel@lists.sourceforge.net \
--cc=error27@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).