From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] netfilter: nf_ct_tcp: fix flow recovery with TCP window tracking enabled
Date: Thu, 15 Jul 2010 13:55:05 +0200 [thread overview]
Message-ID: <4C3EF719.6020208@netfilter.org> (raw)
In-Reply-To: <4C3ED1F5.3050400@trash.net>
On 15/07/10 11:16, Patrick McHardy wrote:
> Am 12.07.2010 18:59, schrieb Pablo Neira Ayuso:
>> This patch adds the missing bits to support the recovery of TCP flows
>> without disabling window tracking (aka be_liberal). To ensure a
>> successful recovery, we have to inject the window scale factor via
>> ctnetlink.
>>
>> This patch has been tested with a development snapshot of conntrackd
>> and the new clause `TCPWindowTracking' that allows to perform strict
>> TCP window tracking recovery across fail-overs.
>>
>> With this patch, we don't update the receiver's window until it's not
>> initiated. We require this to perform a successful recovery. Jozsef
>> confirmed in a private email that this spotted a real issue since that
>> should not happen.
>
> Regarding the question whether to put this into nf-2.6.git or
> nf-next.git, does this fix any bugs besides adding support for
> using window tracking with synchronization? I'm not quite sure
> what "a real issue" is supposed to mean in this case.
Hm, no. This is only useful for window tracking with synchronization (or
any similar application using ctnetlink). Better push it into
nf-next-2.6.git.
next prev parent reply other threads:[~2010-07-15 11:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 16:59 [PATCH 0/2] A couple of netfilter fixes Pablo Neira Ayuso
2010-07-12 16:59 ` [PATCH 1/2] netfilter: nf_ct_tcp: fix flow recovery with TCP window tracking enabled Pablo Neira Ayuso
2010-07-15 9:16 ` Patrick McHardy
2010-07-15 11:55 ` Pablo Neira Ayuso [this message]
2010-07-15 15:10 ` Patrick McHardy
2010-07-12 17:00 ` [PATCH 2/2] netfilter: nfnetlink_queue: add definition of aligned_be64 for user-space apps Pablo Neira Ayuso
2010-07-15 9:19 ` Patrick McHardy
2010-07-15 11:59 ` Pablo Neira Ayuso
2010-07-15 15:07 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3EF719.6020208@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).