Re: [PATCH 1/2] netfilter: nf_ct_tcp: fix flow recovery with TCP window tracking enabled

[Patrick McHardy <kaber@trash.net>]

Am 15.07.2010 13:55, schrieb Pablo Neira Ayuso:
> On 15/07/10 11:16, Patrick McHardy wrote:
>> Am 12.07.2010 18:59, schrieb Pablo Neira Ayuso:
>>> This patch adds the missing bits to support the recovery of TCP flows
>>> without disabling window tracking (aka be_liberal). To ensure a
>>> successful recovery, we have to inject the window scale factor via
>>> ctnetlink.
>>>
>>> This patch has been tested with a development snapshot of conntrackd
>>> and the new clause `TCPWindowTracking' that allows to perform strict
>>> TCP window tracking recovery across fail-overs.
>>>
>>> With this patch, we don't update the receiver's window until it's not
>>> initiated. We require this to perform a successful recovery. Jozsef
>>> confirmed in a private email that this spotted a real issue since that
>>> should not happen.
>>
>> Regarding the question whether to put this into nf-2.6.git or
>> nf-next.git, does this fix any bugs besides adding support for
>> using window tracking with synchronization? I'm not quite sure
>> what "a real issue" is supposed to mean in this case.
> 
> Hm, no. This is only useful for window tracking with synchronization (or
> any similar application using ctnetlink). Better push it into
> nf-next-2.6.git.

Applied to nf-next, thanks.