From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH nf-next-2.6] netfilter: {ip,ip6,arp}_tables: dont block bottom half more than necessary Date: Mon, 02 Aug 2010 16:54:08 +0200 Message-ID: <4C56DC10.9060301@trash.net> References: <1279898595.2481.69.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Netfilter Development Mailinglist , netdev To: Eric Dumazet Return-path: Received: from stinky.trash.net ([213.144.137.162]:61299 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959Ab0HBOyK (ORCPT ); Mon, 2 Aug 2010 10:54:10 -0400 In-Reply-To: <1279898595.2481.69.camel@edumazet-laptop> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 23.07.2010 17:23, Eric Dumazet wrote: > We currently disable BH for the whole duration of get_counters() > > On machines with a lot of cpus and large tables, this might be too long. > > We can disable preemption during the whole function, and disable BH only > while fetching counters for the current cpu. > Applied, thanks Eric.