From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Luciano Coelho <luciano.coelho@nokia.com>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
sameo@linux.intel.com, janne.ylalehto@nokia.com
Subject: Re: [PATCH RESEND 1/3] netfilter: xtables: inclusion of xt_condition
Date: Thu, 16 Sep 2010 07:38:09 +0200 [thread overview]
Message-ID: <4C91AD41.1020802@trash.net> (raw)
In-Reply-To: <alpine.LNX.2.01.1009152309140.6445@obet.zrqbmnf.qr>
On 15.09.2010 23:09, Jan Engelhardt wrote:
>
> On Wednesday 2010-09-15 22:59, Patrick McHardy wrote:
>> On 15.09.2010 22:52, Jan Engelhardt wrote:
>>>
>>> On Wednesday 2010-09-15 22:39, Patrick McHardy wrote:
>>>> Am 17.08.2010 10:36, schrieb Luciano Coelho:
>>>>> +/* Defaults, these can be overridden on the module command-line. */
>>>>> +static unsigned int condition_list_perms = S_IRUGO | S_IWUSR;
>>>>> +static unsigned int condition_uid_perms = 0;
>>>>> +static unsigned int condition_gid_perms = 0;
>>>>
>>>> I'm not sure whether we already discussed this, but this isn't
>>>> useful if namespaces are used since the IDs aren't global.
>>>
>>> Well it's also done for other xt modules that offer a procfs interface.
>>> It does not really cost much to have this present I'd say.
>>
>> They should simply set the permissions for the current namespace.
>>
> IIRC, the namespace stuff was going to be a later patch to keep
> early patches simpler.
I'm fine with that as long as its done before merging the patches
upstream.
next prev parent reply other threads:[~2010-09-16 5:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 8:36 [PATCH RESEND 0/3] netfilter: xtables: inclusion of condition match and target Luciano Coelho
2010-08-17 8:36 ` [PATCH RESEND 1/3] netfilter: xtables: inclusion of xt_condition Luciano Coelho
2010-09-15 20:39 ` Patrick McHardy
2010-09-15 20:52 ` Jan Engelhardt
2010-09-15 20:59 ` Patrick McHardy
2010-09-15 21:09 ` Jan Engelhardt
2010-09-16 5:38 ` Patrick McHardy [this message]
2010-09-21 20:02 ` Luciano Coelho
2010-09-22 6:46 ` Patrick McHardy
2010-09-21 19:59 ` Luciano Coelho
2010-08-17 8:36 ` [PATCH RESEND 2/3] netfilter: xt_condition: change the value from boolean to u32 Luciano Coelho
2010-09-15 20:41 ` Patrick McHardy
2010-09-15 20:46 ` Jan Engelhardt
2010-09-21 20:00 ` Luciano Coelho
2010-08-17 8:36 ` [PATCH RESEND 3/3] netfilter: xt_condition: add condition target support Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C91AD41.1020802@trash.net \
--to=kaber@trash.net \
--cc=janne.ylalehto@nokia.com \
--cc=jengelh@medozas.de \
--cc=luciano.coelho@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).