From: Patrick McHardy <kaber@trash.net>
To: Simon Horman <horms@verge.net.au>
Cc: Julian Anastasov <ja@ssi.bg>,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] ipvs: Netfilter connection tracking changes
Date: Tue, 21 Sep 2010 16:58:43 +0200 [thread overview]
Message-ID: <4C98C823.1010204@trash.net> (raw)
In-Reply-To: <20100919120010.GB18134@verge.net.au>
Am 19.09.2010 14:00, schrieb Simon Horman:
> On Fri, Sep 17, 2010 at 10:38:14PM +0300, Julian Anastasov wrote:
>>
>> Hello,
>>
>> On Fri, 17 Sep 2010, Patrick McHardy wrote:
>>
>>> This one doesn't compile cleanly with CONFIG_IP_VS_NFCT=n:
>>>
>>> CC [M] net/netfilter/ipvs/ip_vs_ftp.o
>>> net/netfilter/ipvs/ip_vs_ftp.c: In function 'ip_vs_ftp_out':
>>> net/netfilter/ipvs/ip_vs_ftp.c:242: error: implicit declaration of
>>> function 'ip_vs_nfct_expect_related'
>>
>> I'm able to reproduce it only by commenting
>> CONFIG_IP_VS_FTP and CONFIG_IP_VS_NFCT and then this command fails:
>>
>> make net/netfilter/ipvs/ip_vs_ftp.o
>>
>> In all other cases if CONFIG_IP_VS_FTP is enabled
>> the 'select IP_VS_NFCT' does its job and enables
>> CONFIG_IP_VS_NFCT. Am I missing something?
>>
>>> Please fix this and resend.
>
> I saw the same problem as Patrick when I ran
>
> $ make oldconfig
> $ make M=net/netfilter/ipvs/
>
> However, it went away once I ran
>
> $ make
That might indeed have been the problem, I can't recall, but
sometimes I just build the affected subdirectories until I've
applied the last patch of a series.
next prev parent reply other threads:[~2010-09-21 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 20:46 [PATCH 2/3] ipvs: Netfilter connection tracking changes Julian Anastasov
2010-09-17 12:28 ` Patrick McHardy
2010-09-17 19:38 ` Julian Anastasov
2010-09-19 12:00 ` Simon Horman
2010-09-21 14:58 ` Patrick McHardy [this message]
2010-09-21 14:56 ` Patrick McHardy
2010-09-21 15:36 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C98C823.1010204@trash.net \
--to=kaber@trash.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).