From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH RESEND 1/3] netfilter: xtables: inclusion of xt_condition Date: Wed, 22 Sep 2010 08:46:54 +0200 Message-ID: <4C99A65E.7080606@trash.net> References: <1282034213-1829-1-git-send-email-luciano.coelho@nokia.com> <1282034213-1829-2-git-send-email-luciano.coelho@nokia.com> <4C912EFC.9070406@trash.net> <4C9133A0.7050601@trash.net> <4C91AD41.1020802@trash.net> <1285099327.10579.20.camel@powerslave> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Jan Engelhardt , "netfilter-devel@vger.kernel.org" , "netdev@vger.kernel.org" , "sameo@linux.intel.com" , "Ylalehto Janne (Nokia-MS/Tampere)" To: Luciano Coelho Return-path: Received: from stinky.trash.net ([213.144.137.162]:53428 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731Ab0IVGqz (ORCPT ); Wed, 22 Sep 2010 02:46:55 -0400 In-Reply-To: <1285099327.10579.20.camel@powerslave> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Am 21.09.2010 22:02, schrieb Luciano Coelho: > On Thu, 2010-09-16 at 07:38 +0200, ext Patrick McHardy wrote: >> On 15.09.2010 23:09, Jan Engelhardt wrote: >>> >>> On Wednesday 2010-09-15 22:59, Patrick McHardy wrote: >>>> On 15.09.2010 22:52, Jan Engelhardt wrote: >>>>> >>>>> On Wednesday 2010-09-15 22:39, Patrick McHardy wrote: >>>>>> Am 17.08.2010 10:36, schrieb Luciano Coelho: >>>>>>> +/* Defaults, these can be overridden on the module command-line. */ >>>>>>> +static unsigned int condition_list_perms = S_IRUGO | S_IWUSR; >>>>>>> +static unsigned int condition_uid_perms = 0; >>>>>>> +static unsigned int condition_gid_perms = 0; >>>>>> >>>>>> I'm not sure whether we already discussed this, but this isn't >>>>>> useful if namespaces are used since the IDs aren't global. >>>>> >>>>> Well it's also done for other xt modules that offer a procfs interface. >>>>> It does not really cost much to have this present I'd say. >>>> >>>> They should simply set the permissions for the current namespace. >>>> >>> IIRC, the namespace stuff was going to be a later patch to keep >>> early patches simpler. >> >> I'm fine with that as long as its done before merging the patches >> upstream. > > I'll try to fix this and create a new patch on top of the existing ones, > then I'll send them all as a single patchset. Sounds good, thanks.