From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Paris <eparis@redhat.com>
Cc: Jan Engelhardt <jengelh@medozas.de>,
linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
netfilter@vger.kernel.org, paul.moore@hp.com, jmorris@namei.org,
selinux@tycho.nsa.gov, sds@tycho.nsa.gov,
linux-security-module@vger.kernel.org,
mr.dash.four@googlemail.com
Subject: Re: [PATCH 2/5] secmark: make secmark object handling generic
Date: Tue, 12 Oct 2010 20:15:38 +0200 [thread overview]
Message-ID: <4CB4A5CA.7050300@netfilter.org> (raw)
In-Reply-To: <1286905533.2608.21.camel@dhcp235-107.rdu.redhat.com>
On 12/10/10 19:45, Eric Paris wrote:
> On Tue, 2010-10-12 at 19:24 +0200, Pablo Neira Ayuso wrote:
>> On 12/10/10 18:26, Jan Engelhardt wrote:
>>> On Tuesday 2010-10-12 17:40, Eric Paris wrote:
>
>>>> static struct xt_target secmark_tg_reg __read_mostly = {
>>>> - .name = "SECMARK",
>>>> - .revision = 0,
>>>> - .family = NFPROTO_UNSPEC,
>>>> - .checkentry = secmark_tg_check,
>>>> - .destroy = secmark_tg_destroy,
>>>> - .target = secmark_tg,
>>>> - .targetsize = sizeof(struct xt_secmark_target_info),
>>>> - .me = THIS_MODULE,
>>>> + .name = "SECMARK",
>>>> + .revision = 0,
>>>> + .family = NFPROTO_UNSPEC,
>>>> + .checkentry = secmark_tg_check,
>>>> + .destroy = secmark_tg_destroy,
>>>> + .target = secmark_tg,
>>>> + .targetsize = sizeof(struct xt_secmark_target_info),
>>>> + .me = THIS_MODULE,
>>>> };
>>
>> I think that we don't need that extra tab above.
>
> Are you saying that you prefer lots of spaces to get alignment rather
> than the single tab? I see examples of both in other struct xt_target
> definitions. I didn't make any syntax changes to this struct, so my
> guess is that I made this change when I discovered eight spaces in a row
> as I was checking the file for tab->space screw-ups before submission.
> Since this is a whitespace change in the middle of a real patch I guess
> I can drop the hunk entirely if that's what you are asking for....
I think that this is a cleanup that should go into a different patch,
that's all.
next prev parent reply other threads:[~2010-10-12 18:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 15:40 [PATCH 1/5] secmark: do not return early if there was no error Eric Paris
2010-10-12 15:40 ` [PATCH 2/5] secmark: make secmark object handling generic Eric Paris
2010-10-12 16:26 ` Jan Engelhardt
2010-10-12 17:24 ` Pablo Neira Ayuso
2010-10-12 17:45 ` Eric Paris
2010-10-12 17:53 ` Jan Engelhardt
2010-10-12 18:15 ` Pablo Neira Ayuso [this message]
2010-10-12 22:55 ` Paul Moore
2010-10-12 23:01 ` Eric Paris
2010-10-12 23:06 ` Paul Moore
2010-10-12 23:14 ` Eric Paris
2010-10-12 23:20 ` Paul Moore
2010-10-12 15:40 ` [PATCH 3/5] security: secid_to_secctx returns len when data is NULL Eric Paris
2010-10-12 23:04 ` Paul Moore
2010-10-12 15:40 ` [PATCH 4/5] conntrack: export lsm context rather than internal secid via netlink Eric Paris
2010-10-12 23:14 ` Paul Moore
2010-10-12 23:24 ` Eric Paris
2010-10-13 13:41 ` Paul Moore
2010-10-12 15:40 ` [PATCH 5/5] secmark: export secctx, drop secmark in procfs Eric Paris
2010-10-12 23:19 ` Paul Moore
2010-10-12 23:27 ` Eric Paris
2010-10-12 22:52 ` [PATCH 1/5] secmark: do not return early if there was no error Paul Moore
2010-10-12 23:38 ` James Morris
2010-10-12 23:50 ` Eric Paris
2010-10-13 4:07 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB4A5CA.7050300@netfilter.org \
--to=pablo@netfilter.org \
--cc=eparis@redhat.com \
--cc=jengelh@medozas.de \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mr.dash.four@googlemail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).