From: Patrick McHardy <kaber@trash.net>
To: Changli Gao <xiaosuo@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: don't always initialize ct->proto
Date: Mon, 25 Oct 2010 17:43:06 +0200 [thread overview]
Message-ID: <4CC5A58A.8070204@trash.net> (raw)
In-Reply-To: <1287888016-25213-1-git-send-email-xiaosuo@gmail.com>
Am 24.10.2010 04:40, schrieb Changli Gao:
> ct->proto is big(60 bytes) due to structure ip_ct_tcp, and we don't need
> to initialize the whole for all the other protocols. This patch moves
> proto to the end of structure nf_conn, and pushes the initialization down
> to the individual protocols.
Looks fine to me. Please resend once net-next is open again. Thanks!
prev parent reply other threads:[~2010-10-25 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 2:40 [PATCH] netfilter: don't always initialize ct->proto Changli Gao
2010-10-24 8:27 ` Jan Engelhardt
2010-10-24 8:40 ` Changli Gao
2010-10-25 15:43 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC5A58A.8070204@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).