From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] libxtables: change option precedence order to be intuitive
Date: Thu, 28 Oct 2010 11:54:28 +0200 [thread overview]
Message-ID: <4CC94854.8010306@trash.net> (raw)
In-Reply-To: <alpine.LNX.2.01.1010252357270.18188@obet.zrqbmnf.qr>
On 25.10.2010 23:57, Jan Engelhardt wrote:
> On Tuesday 2010-10-19 17:16, Jan Engelhardt wrote:
>
>> When using `-m mark --mark 2 -m connmark --mark 2`, the user currently
>> gets an error about the (libxt_mark) --mark option being used twice.
>> This is because libxt_connmark's option table does not override any
>> previous options. This patch changes this behavior, since the current
>> behavior does not allow connmark's option to be used at all, which is
>> illogical.
>
> As per fw's suggestion, I should nag you every 48 hours ;-)
>
> Really, this should be in the next tag.
This stuff is pretty fragile and whenever we changed it, something broke
for users. Why not simply add new options (--connmark etc). That would
also be more consistent with the other extensions.
next prev parent reply other threads:[~2010-10-28 9:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 15:16 iptables: option precedence order change Jan Engelhardt
2010-10-19 15:16 ` [PATCH] libxtables: change option precedence order to be intuitive Jan Engelhardt
2010-10-25 21:57 ` Jan Engelhardt
2010-10-28 9:54 ` Patrick McHardy [this message]
2010-10-28 10:54 ` Jan Engelhardt
2010-10-29 5:26 ` Changli Gao
2010-10-29 12:59 ` Jan Engelhardt
2010-10-29 17:04 ` Patrick McHardy
2010-11-15 10:38 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2010-11-15 12:28 Jan Engelhardt
2010-11-15 12:56 ` Patrick McHardy
2010-11-15 13:13 ` Jan Engelhardt
2010-11-15 13:15 ` Patrick McHardy
2010-11-15 13:41 ` Jan Engelhardt
2010-11-15 13:46 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC94854.8010306@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).