From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: geert@linux-m68k.org, bazsi@balabit.hu, hidden@balabit.hu,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: tproxy: added IPv6 support to the socket match
Date: Fri, 29 Oct 2010 16:31:35 +0200 [thread overview]
Message-ID: <4CCADAC7.5040309@trash.net> (raw)
In-Reply-To: <20101028.130025.102564000.davem@davemloft.net>
Am 28.10.2010 22:00, schrieb David Miller:
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Date: Thu, 28 Oct 2010 20:51:43 +0200
>
>>> + u8 tproto;
>>
>> tproto is unsigned...
>>
>>> + const struct xt_socket_mtinfo1 *info = (struct xt_socket_mtinfo1 *) par->matchinfo;
>>> +
>>> + tproto = ipv6_find_hdr(skb, &thoff, -1, NULL);
>>
>> but ipv6_find_hdr() returns int, and negative values for errors...
>
> Thanks Geert, I'll fix it like so:
>
> --------------------
> netfilter: xt_socket: Make tproto signed in socket_mt6_v1().
>
> Otherwise error indications from ipv6_find_hdr() won't be noticed.
>
> This required making the protocol argument to extract_icmp6_fields()
> signed too.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Thanks for taking care of this Dave.
prev parent reply other threads:[~2010-10-29 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201010231923.o9NJNK9U013494@hera.kernel.org>
2010-10-28 18:51 ` tproxy: added IPv6 support to the socket match Geert Uytterhoeven
2010-10-28 20:00 ` David Miller
2010-10-29 14:31 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCADAC7.5040309@trash.net \
--to=kaber@trash.net \
--cc=akpm@linux-foundation.org \
--cc=bazsi@balabit.hu \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=hidden@balabit.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).