Re: [PATCH] libxtables: change option precedence order to be intuitive

[Patrick McHardy <kaber@trash.net>]

Am 29.10.2010 14:59, schrieb Jan Engelhardt:
> On Friday 2010-10-29 07:26, Changli Gao wrote:
>>>>>
>>>>>> When using `-m mark --mark 2 -m connmark --mark 2`, the user currently
>>>>>> gets an error about the (libxt_mark) --mark option being used twice.
>>>>>> This is because libxt_connmark's option table does not override any
>>>>>> previous options. This patch changes this behavior, since the current
>>>>>> behavior does not allow connmark's option to be used at all, which is
>>>>>> illogical.
>>>>>
>>>>> As per fw's suggestion, I should nag you every 48 hours ;-)
>>>>>
>>>>> Really, this should be in the next tag.
>>>>
>>>> This stuff is pretty fragile and whenever we changed it, something broke
>>>> for users. Why not simply add new options  (--connmark etc). That would
>>>> also be more consistent with the other extensions.
>>>
>>> Adding new options does not fix the real problem, and you cannot easily
>>> ensure that no options will clash with another.
>>> And what do you do when you use -m hashlimit --hashlimit-name abc -m
>>> hashlimit --hashlimit-name def? You can't use new options here.
>>
>> I think this issue was discussed in this thread:
>> http://marc.info/?l=netfilter-devel&m=121881908205975&w=2 . And the
>> above command should be OK. Did you test it?
> 
> Well ok bad example; -m hashlimit twice works, as does your linked 
> example when replacing -m a and -m b with -m mac.

I've applied the patch to iptables-next, but if something breaks
I'll revert it and add --connmark- prefixed options.