From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Frederic Leroy <fredo@starox.org>, netfilter-devel@vger.kernel.org
Subject: Re: [arptables] rfc: add classify target
Date: Tue, 09 Nov 2010 15:25:26 +0100 [thread overview]
Message-ID: <4CD959D6.1090705@trash.net> (raw)
In-Reply-To: <alpine.LNX.2.01.1011071616150.21289@obet.zrqbmnf.qr>
Am 07.11.2010 16:18, schrieb Jan Engelhardt:
> On Sunday 2010-11-07 15:26, Frederic Leroy wrote:
>>
>> I wrote a new classify target. Patches for both current linux-stable and
>> arptables cvs are joined.
>>
>> +++ b/net/ipv4/netfilter/arpt_classify.c
>> @@ -0,0 +1,41 @@
>> +/* module that allows classification of arp packet */
>> +#include <linux/module.h>
>> +#include <linux/netfilter.h>
>> +#include <linux/netfilter/x_tables.h>
>> +#include <linux/netfilter_arp/arpt_classify.h>
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_AUTHOR("Frederic Leroy <fredo@starox.org>");
>> +MODULE_DESCRIPTION("arptables arp classify target");
>> +
>> +static unsigned int
>> +target(struct sk_buff *skb, const struct xt_action_param *par)
>> +{
>> + const struct arpt_classify *classify = par->targinfo;
>> +
>> + skb->priority=classify->priority;
>> +
>> + return XT_CONTINUE;
>> +}
>
> Why did you not update xt_CLASSIFY instead?
Actually we already register for NFPROTO_UNSPEC, so simply
adding a userspace extension should do the job.
next prev parent reply other threads:[~2010-11-09 14:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 14:26 [arptables] rfc: add classify target Frederic Leroy
2010-11-07 15:18 ` Jan Engelhardt
2010-11-09 14:25 ` Patrick McHardy [this message]
2010-11-09 16:10 ` Frederic Leroy
2010-11-09 16:48 ` Patrick McHardy
2010-11-09 17:39 ` Bart De Schuymer
2010-11-09 20:18 ` Frederic Leroy
2010-11-09 20:28 ` Jan Engelhardt
2010-11-09 20:34 ` Frederic Leroy
2010-11-09 21:27 ` Jan Engelhardt
2010-11-09 21:38 ` Frederic Leroy
2010-11-09 20:51 ` Frederic Leroy
2010-11-11 10:38 ` Patrick McHardy
2010-11-11 11:45 ` Frederic Leroy
2010-11-12 7:49 ` Patrick McHardy
2010-11-13 15:29 ` Frederic Leroy
2010-11-14 15:36 ` Bart De Schuymer
2010-11-15 12:32 ` Frederic Leroy
2010-11-15 19:31 ` Bart De Schuymer
2010-11-15 10:44 ` Patrick McHardy
2010-11-15 12:28 ` [PATCH] netfilter: xtables: add arp support, allow CLASSIFY target on any table Frederic Leroy
2010-11-15 12:59 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD959D6.1090705@trash.net \
--to=kaber@trash.net \
--cc=fredo@starox.org \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).