From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/5] include: use C++ headers in C++ mode
Date: Thu, 11 Nov 2010 14:15:40 +0100 [thread overview]
Message-ID: <4CDBEC7C.8030107@netfilter.org> (raw)
In-Reply-To: <alpine.LNX.2.01.1011111358370.13616@obet.zrqbmnf.qr>
On 11/11/10 13:59, Jan Engelhardt wrote:
> On Thursday 2010-11-11 13:57, Pablo Neira Ayuso wrote:
>
>> On 11/11/10 00:08, Jan Engelhardt wrote:
>>> diff --git a/include/libmnl/libmnl.h b/include/libmnl/libmnl.h
>>> index 7094af2..37c502a 100644
>>> --- a/include/libmnl/libmnl.h
>>> +++ b/include/libmnl/libmnl.h
>>> @@ -1,13 +1,16 @@
>>> #ifndef _LIBMNL_H_
>>> #define _LIBMNL_H_
>>>
>>> -#include <stdio.h>
>>> -#include <stdint.h>
>>> +#ifdef __cplusplus
>>> +# include <cstdio>
>>> +# include <cstdint>
>>> +#else
>>> +# include <stdbool.h> /* not in C++ */
>>> +# include <stdio.h>
>>> +# include <stdint.h>
>>> +#endif
>>> #include <sys/socket.h> /* for sa_family_t */
>>> #include <linux/netlink.h>
>>> -#ifndef __cplusplus
>>> -# include <stdbool.h>
>>> -#endif
>>
>> A c++ example compiles fine without this here, so do we really need
>> these extra ifdef's?
>
> Well there is a purpose for having <cXXX> over <XXX.h> in C++. IIRC it
> was proper namespacing of Standard Library functions.
I'm looking at other library code but I don't find any doing this. If
you can point to any, I'd appreciate it.
next prev parent reply other threads:[~2010-11-11 13:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 23:07 libmnl misc patches Nov 11 Jan Engelhardt
2010-11-10 23:08 ` [PATCH 1/5] socket: constify a struct sockaddr_nl Jan Engelhardt
2010-11-11 12:56 ` Pablo Neira Ayuso
2010-11-10 23:08 ` [PATCH 2/5] include: use C++ headers in C++ mode Jan Engelhardt
2010-11-11 12:57 ` Pablo Neira Ayuso
2010-11-11 12:59 ` Jan Engelhardt
2010-11-11 13:15 ` Pablo Neira Ayuso [this message]
2010-11-13 18:19 ` Jan Engelhardt
2010-11-16 10:04 ` Pablo Neira Ayuso
2013-06-07 8:35 ` Thomas Jarosch
2013-06-08 13:38 ` Jan Engelhardt
2010-11-10 23:08 ` [PATCH 3/5] nlmsg: use bool for all _ok functions Jan Engelhardt
2010-11-11 12:59 ` Pablo Neira Ayuso
2010-11-10 23:08 ` [PATCH 4/5] attr: remove redundant check for NULL Jan Engelhardt
2010-11-11 13:02 ` Pablo Neira Ayuso
2010-11-10 23:08 ` [PATCH 5/5] attr: avoid multiple definition of hidden variable Jan Engelhardt
2010-11-11 13:08 ` Pablo Neira Ayuso
2010-11-11 13:25 ` Jan Engelhardt
2010-11-11 17:47 ` Pablo Neira Ayuso
2010-11-11 20:53 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDBEC7C.8030107@netfilter.org \
--to=pablo@netfilter.org \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).