From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [arptables] rfc: add classify target Date: Fri, 12 Nov 2010 08:49:59 +0100 Message-ID: <4CDCF1A7.2050402@trash.net> References: <20101107152636.56f62235@caresse> <4CD959D6.1090705@trash.net> <20101109161047.GB25549@sd-11162.dedibox.fr> <4CD98746.4050100@pandora.be> <20101109211834.4da8e412@caresse> <20101109215126.502a155e@caresse> <4CDBC7B1.2020101@trash.net> <20101111124505.345643a3@caresse> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jan Engelhardt , Bart De Schuymer , netfilter-devel@vger.kernel.org To: Frederic Leroy Return-path: Received: from stinky.trash.net ([213.144.137.162]:56226 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289Ab0KLHt6 (ORCPT ); Fri, 12 Nov 2010 02:49:58 -0500 In-Reply-To: <20101111124505.345643a3@caresse> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 11.11.2010 12:45, Frederic Leroy wrote: > Le Thu, 11 Nov 2010 11:38:41 +0100, > Patrick McHardy a =E9crit : >=20 >> On 09.11.2010 21:51, Frederic Leroy wrote: >>> Le Tue, 9 Nov 2010 21:28:09 +0100 (CET), >>> Jan Engelhardt a =E9crit : >>> >>>> Alas, when I originally coded NFPROTO_UNSPEC wildcard support, >>>> I allowed for same-rev overloading, as in: >>>> >>>> static struct xt_target classify_tg_reg[] __read_mostly =3D { >>>> { >>>> [...] >>>> }; >>>> >>> >>> Here is a patch against my previous patch with your insights. >>> I had time to test it.=20 >> >> This seems like the best we can do for now. Does it work as intended= ? >=20 > Yes, it works as intended.=20 >=20 > Nevertheless, I plan to update kernel and arptables to match NF_INET_= *. > I should have time to do it for sunday.=20 You can't change the numerical values, that would break compatibility. That basically leaves the option of using NF_INET_PRE_ROUTING instead of NF_ARP_IN etc, which would make things highly confusing :) -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html