From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart De Schuymer Subject: Re: [arptables] rfc: add classify target Date: Sun, 14 Nov 2010 16:36:18 +0100 Message-ID: <4CE001F2.8020600@pandora.be> References: <20101107152636.56f62235@caresse> <4CD959D6.1090705@trash.net> <20101109161047.GB25549@sd-11162.dedibox.fr> <4CD98746.4050100@pandora.be> <20101109211834.4da8e412@caresse> <20101109215126.502a155e@caresse> <4CDBC7B1.2020101@trash.net> <20101111124505.345643a3@caresse> <4CDCF1A7.2050402@trash.net> <20101113162934.768e4a3c@caresse> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Patrick McHardy , Jan Engelhardt , netfilter-devel@vger.kernel.org To: Frederic Leroy Return-path: Received: from gerard.telenet-ops.be ([195.130.132.48]:53996 "EHLO gerard.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756068Ab0KNPlW (ORCPT ); Sun, 14 Nov 2010 10:41:22 -0500 In-Reply-To: <20101113162934.768e4a3c@caresse> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Apart from my comments below, the userspace patch looks ok: - I would line up the help and man page entries between arptables and iptables so noone gets confused. Also, the man page entry refers to set-class-mac. - In final_check() you should make sure that the priority has been set (similar to what's done in libxt_CLASSIFY.c). cheers, Bart On 13-11-10 16:29, Frederic Leroy wrote: > Le Fri, 12 Nov 2010 08:49:59 +0100, > Patrick McHardy a =E9crit : > >> On 11.11.2010 12:45, Frederic Leroy wrote: >>> Le Thu, 11 Nov 2010 11:38:41 +0100, >>> Patrick McHardy a =E9crit : >> You can't change the numerical values, that would break compatibilit= y. >> That basically leaves the option of using NF_INET_PRE_ROUTING instea= d >> of NF_ARP_IN etc, which would make things highly confusing :) > There is no much use of NF_ARP_* in the google codesearch world, but = I > understand the need to not break compatibility. > > So I joined my last patches to xt_CLASSIFY and arptables.=20 > > I checked that : > - modules are autoloaded > - it works as intended for marking cos on vlan interface. > --=20 Bart De Schuymer www.artinalgorithms.be -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html