From: Bart De Schuymer <bdschuym@pandora.be>
To: Frederic Leroy <fredo@starox.org>
Cc: Patrick McHardy <kaber@trash.net>,
Jan Engelhardt <jengelh@medozas.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [arptables] rfc: add classify target
Date: Mon, 15 Nov 2010 20:31:44 +0100 [thread overview]
Message-ID: <4CE18AA0.20204@pandora.be> (raw)
In-Reply-To: <20101115133248.5815e9c1@caresse>
Applied,
Thanks Frederic.
Bart
On 15-11-10 13:32, Frederic Leroy wrote:
> Le Sun, 14 Nov 2010 16:36:18 +0100,
> Bart De Schuymer<bdschuym@pandora.be> a écrit :
>
>> Apart from my comments below, the userspace patch looks ok:
>> - I would line up the help and man page entries between arptables and
>> iptables so noone gets confused. Also, the man page entry refers to
>> set-class-mac.
>> - In final_check() you should make sure that the priority has been set
>> (similar to what's done in libxt_CLASSIFY.c).
> Here it is, largely borrowed from iptables.
>
> Cheers,
>
--
Bart De Schuymer
www.artinalgorithms.be
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-11-15 19:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 14:26 [arptables] rfc: add classify target Frederic Leroy
2010-11-07 15:18 ` Jan Engelhardt
2010-11-09 14:25 ` Patrick McHardy
2010-11-09 16:10 ` Frederic Leroy
2010-11-09 16:48 ` Patrick McHardy
2010-11-09 17:39 ` Bart De Schuymer
2010-11-09 20:18 ` Frederic Leroy
2010-11-09 20:28 ` Jan Engelhardt
2010-11-09 20:34 ` Frederic Leroy
2010-11-09 21:27 ` Jan Engelhardt
2010-11-09 21:38 ` Frederic Leroy
2010-11-09 20:51 ` Frederic Leroy
2010-11-11 10:38 ` Patrick McHardy
2010-11-11 11:45 ` Frederic Leroy
2010-11-12 7:49 ` Patrick McHardy
2010-11-13 15:29 ` Frederic Leroy
2010-11-14 15:36 ` Bart De Schuymer
2010-11-15 12:32 ` Frederic Leroy
2010-11-15 19:31 ` Bart De Schuymer [this message]
2010-11-15 10:44 ` Patrick McHardy
2010-11-15 12:28 ` [PATCH] netfilter: xtables: add arp support, allow CLASSIFY target on any table Frederic Leroy
2010-11-15 12:59 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE18AA0.20204@pandora.be \
--to=bdschuym@pandora.be \
--cc=fredo@starox.org \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).