netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] libxt_conntrack: fix --ctdir save/dump output format
@ 2010-11-17 14:27 Florian Westphal
  2010-11-17 14:55 ` Patrick McHardy
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2010-11-17 14:27 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Florian Westphal

$ iptables-save | iptables-restore
iptables-restore v1.4.6: conntrack: Bad value for "--ctdir" option: "ORIGINAL-j"

Signed-off-by: Florian Westphal <fwestphal@astaro.com>
---
 extensions/libxt_conntrack.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/extensions/libxt_conntrack.c b/extensions/libxt_conntrack.c
index 6c4a9cd..dd3fb6f 100644
--- a/extensions/libxt_conntrack.c
+++ b/extensions/libxt_conntrack.c
@@ -974,9 +974,9 @@ matchinfo_print(const void *ip, const struct xt_entry_match *match, int numeric,
 
 	if (sinfo->flags & XT_CONNTRACK_DIRECTION) {
 		if (sinfo->invflags & XT_CONNTRACK_DIRECTION)
-			printf("%sctdir REPLY", optpfx);
+			printf("%sctdir REPLY ", optpfx);
 		else
-			printf("%sctdir ORIGINAL", optpfx);
+			printf("%sctdir ORIGINAL ", optpfx);
 	}
 
 }
@@ -1079,9 +1079,9 @@ conntrack_dump(const struct xt_conntrack_mtinfo2 *info, const char *prefix,
 
 	if (info->match_flags & XT_CONNTRACK_DIRECTION) {
 		if (info->invert_flags & XT_CONNTRACK_DIRECTION)
-			printf("%sctdir REPLY", prefix);
+			printf("%sctdir REPLY ", prefix);
 		else
-			printf("%sctdir ORIGINAL", prefix);
+			printf("%sctdir ORIGINAL ", prefix);
 	}
 }
 
-- 
1.7.2.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] libxt_conntrack: fix --ctdir save/dump output format
  2010-11-17 14:27 [PATCH 1/1] libxt_conntrack: fix --ctdir save/dump output format Florian Westphal
@ 2010-11-17 14:55 ` Patrick McHardy
  0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2010-11-17 14:55 UTC (permalink / raw)
  To: Florian Westphal; +Cc: netfilter-devel

On 17.11.2010 15:27, Florian Westphal wrote:
> $ iptables-save | iptables-restore
> iptables-restore v1.4.6: conntrack: Bad value for "--ctdir" option: "ORIGINAL-j"

Amazing, nobody noticed for almost two years.

Applied, thanks Florian.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-11-17 14:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-17 14:27 [PATCH 1/1] libxt_conntrack: fix --ctdir save/dump output format Florian Westphal
2010-11-17 14:55 ` Patrick McHardy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).