netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	eric.dumazet@gmail.com, linux-net@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	horms@verge.net.au, netfilter-devel@vger.kernel.org
Subject: Re: error while building the kernel Mainline
Date: Thu, 18 Nov 2010 21:32:11 +0100	[thread overview]
Message-ID: <4CE58D4B.6070105@trash.net> (raw)
In-Reply-To: <4CE57C06.4080105@gmail.com>

Am 18.11.2010 20:18, schrieb Justin P. Mattock:
> On 11/18/2010 10:20 AM, Patrick McHardy wrote:
>> Am 18.11.2010 19:13, schrieb Justin P. Mattock:
>>> On 11/18/2010 09:50 AM, David Miller wrote:
>>>> From: Eric Dumazet<eric.dumazet@gmail.com>
>>>> Date: Thu, 18 Nov 2010 18:48:17 +0100
>>>>
>>>>> Let me guess...
>>>>>
>>>>> net/netfilter/nf_conntrack_core is compiled as a module, and ip_vs
>>>>> statically (in vmlinux) ?
>>>>>
>>>>> CONFIG_NF_CONNTRACK=m
>>>>> CONFIG_IP_VS=y
>>>>>
>>>>> We probably need some Kconfig magic ;)
>>>>
>>
>> Please try whether this patch fixes the problem.
>>
>> netfilter: fix IP_VS dependencies
>>
>> When NF_CONNTRACK is enabled, IP_VS uses conntrack symbols.
>> Therefore IP_VS can't be linked statically when conntrack
>> is built modular.
>>
>> Reported-by: Justin P. Mattock<justinmattock@gmail.com>
>> Signed-off-by: Patrick McHardy<kaber@trash.net>
>>
>>
> 
> 
> alright!! doing the above change
> CONFIG_NF_CONNTRACK=y gets a clean build.. as well as reverting
> everything and using your patch..
> 
> Thanks for the fix..

Thanks for testing. Dave, please apply directly, thanks!

  reply	other threads:[~2010-11-18 20:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTikToBjx-4go9mAFCcnTQ5X4Su+57ODoY9C5y_7f@mail.gmail.com>
     [not found] ` <1290093135.2781.167.camel@edumazet-laptop>
     [not found]   ` <4CE561A2.2020600@gmail.com>
2010-11-18 17:48     ` error while building the kernel Mainline Eric Dumazet
2010-11-18 17:50       ` David Miller
2010-11-18 18:12         ` Patrick McHardy
2010-11-18 18:13         ` Justin P. Mattock
2010-11-18 18:20           ` Patrick McHardy
2010-11-18 18:28             ` Justin P. Mattock
2010-11-18 19:18             ` Justin P. Mattock
2010-11-18 20:32               ` Patrick McHardy [this message]
2010-11-18 20:54                 ` David Miller
2010-11-18 21:03                   ` Randy Dunlap
2010-11-18 21:10                     ` David Miller
2010-11-18 21:15                       ` David Miller
2010-11-18 21:48                         ` Patrick McHardy
2010-11-18 23:48                           ` Justin P. Mattock
2010-11-19  0:20                             ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE58D4B.6070105@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@verge.net.au \
    --cc=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).