From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [patch] xtables: use guarded types Date: Thu, 16 Dec 2010 08:28:50 +0100 Message-ID: <4D09BFB2.7040504@trash.net> References: <4D00B2D7.4010401@netfilter.org> <4D01FFC5.90808@netfilter.org> <4D093A49.2060500@trash.net> <4D09457C.5050302@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Pablo Neira Ayuso , Netfilter Developer Mailing List To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:34709 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876Ab0LPH2v (ORCPT ); Thu, 16 Dec 2010 02:28:51 -0500 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 16.12.2010 01:27, Jan Engelhardt wrote: > > On Wednesday 2010-12-15 23:47, Patrick McHardy wrote: >>>> >>>> I'll also gladly apply a patch to get rid of the u_int_XX crap. >>> >>> To be found where? (Choose: kernel/userspace/both) >> >> Both I guess, but I was previously referring to the kernel. > > I do not see the issue with using POSIX types outside of operating > system interface specifications. > So I guess this is in order: > > parent 3a84b3d5de492e40aff7bae5038b06dd6b6041c4 (v1.4.10-17-g3a84b3d) > commit a069355b7933c9afe38b5cb7b251b2ece4fe8456 > Author: Jan Engelhardt > Date: Thu Dec 16 00:59:27 2010 +0100 > > src: use C99/POSIX types > > "u_int" was a non-standardized extension predating C99 on some platforms. While I don't have a real personal preference, most of the remaining networking stack uses uXX types and I know code has been actively converted from C99 types to those. So for consistency we should also use uXX. Sorry for not being clearer about that before.