From: Bart De Schuymer <bdschuym@pandora.be>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: ebt_ip6: allow matching on ipv6-icmp types/codes
Date: Mon, 20 Dec 2010 19:17:03 +0100 [thread overview]
Message-ID: <4D0F9D9F.7090608@pandora.be> (raw)
In-Reply-To: <1292857067-1595-1-git-send-email-fw@strlen.de>
Op 20/12/2010 15:57, Florian Westphal schreef:
> To avoid adding a new match revision icmp type/code are stored
> in the sport/dport area.
>
> Signed-off-by: Florian Westphal<fw@strlen.de>
> Reviewed-by: Holger Eitzenberger<holger@eitzenberger.org>
> ---
> Changes since v1:
> - use u16 where appropriate
> - use proper () in if condition
> - renamed _ports to _pkthdr
> - add comment that sizeof(_pktheader) is also ok in ICMP6 case.
>
> include/linux/netfilter_bridge/ebt_ip6.h | 15 ++++++++--
> net/bridge/netfilter/ebt_ip6.c | 46 ++++++++++++++++++++++--------
> 2 files changed, 46 insertions(+), 15 deletions(-)
>
OK for me.
Reviewed-by: Bart De Schuymer<bdschuym@pandora.be>
next prev parent reply other threads:[~2010-12-20 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 14:57 [PATCH v2] netfilter: ebt_ip6: allow matching on ipv6-icmp types/codes Florian Westphal
2010-12-20 18:17 ` Bart De Schuymer [this message]
2011-01-12 21:15 ` Pablo Neira Ayuso
2011-01-18 20:10 ` Bart De Schuymer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0F9D9F.7090608@pandora.be \
--to=bdschuym@pandora.be \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).