netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* libmnl: build improvements
@ 2010-12-30 23:43 Jan Engelhardt
  2010-12-30 23:43 ` [PATCH 1/2] build: use AM_CPPFLAGS Jan Engelhardt
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jan Engelhardt @ 2010-12-30 23:43 UTC (permalink / raw)
  To: pablo; +Cc: netfilter-devel


The following changes since commit 091286e666a9d34818a875152ac7659b38656f06:

  build: libmnl 1.0.1 release (2010-12-26 21:17:54 +0100)

are available in the git repository at:
  git://dev.medozas.de/libmnl master

Jan Engelhardt (2):
      build: use AM_CPPFLAGS
      build: use only AC_CANONICAL_HOST

 Make_global.am |    2 +-
 configure.ac   |    9 +++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] build: use AM_CPPFLAGS
  2010-12-30 23:43 libmnl: build improvements Jan Engelhardt
@ 2010-12-30 23:43 ` Jan Engelhardt
  2010-12-30 23:43 ` [PATCH 2/2] build: use only AC_CANONICAL_HOST Jan Engelhardt
  2011-01-06  2:21 ` libmnl: build improvements Pablo Neira Ayuso
  2 siblings, 0 replies; 4+ messages in thread
From: Jan Engelhardt @ 2010-12-30 23:43 UTC (permalink / raw)
  To: pablo; +Cc: netfilter-devel

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
 Make_global.am |    2 +-
 configure.ac   |    5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Make_global.am b/Make_global.am
index 7049189..1c9ed63 100644
--- a/Make_global.am
+++ b/Make_global.am
@@ -20,5 +20,5 @@
 #
 LIBVERSION=0:1:0
 
-AM_CPPFLAGS = -I$(top_srcdir)/include
+AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_srcdir}/include
 AM_CFLAGS = ${regular_CFLAGS} ${GCC_FVISIBILITY_HIDDEN}
diff --git a/configure.ac b/configure.ac
index 264242a..819cbf7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -17,10 +17,11 @@ case $target in
 *) AC_MSG_ERROR([Linux only, dude!]);;
 esac
 
-regular_CFLAGS="-D_FILE_OFFSET_BITS=64 \
-	-D_REENTRANT -Wall -Waggregate-return -Wmissing-declarations \
+regular_CPPFLAGS="-D_FILE_OFFSET_BITS=64 -D_REENTRANT"
+regular_CFLAGS="-Wall -Waggregate-return -Wmissing-declarations \
 	-Wmissing-prototypes -Wredundant-decls -Wshadow -Wstrict-prototypes \
 	-Wformat=2 -pipe"
+AC_SUBST([regular_CPPFLAGS])
 AC_SUBST([regular_CFLAGS])
 AC_CONFIG_FILES([Makefile src/Makefile include/Makefile include/libmnl/Makefile include/linux/Makefile examples/Makefile examples/genl/Makefile examples/netfilter/Makefile examples/rtnl/Makefile libmnl.pc doxygen.cfg])
 AC_OUTPUT
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] build: use only AC_CANONICAL_HOST
  2010-12-30 23:43 libmnl: build improvements Jan Engelhardt
  2010-12-30 23:43 ` [PATCH 1/2] build: use AM_CPPFLAGS Jan Engelhardt
@ 2010-12-30 23:43 ` Jan Engelhardt
  2011-01-06  2:21 ` libmnl: build improvements Pablo Neira Ayuso
  2 siblings, 0 replies; 4+ messages in thread
From: Jan Engelhardt @ 2010-12-30 23:43 UTC (permalink / raw)
  To: pablo; +Cc: netfilter-devel

Calculating AC_CANONICAL_TARGET is superfluous, because libmnl
is not a code generator.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
 configure.ac |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 819cbf7..82a6ce4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,7 +1,7 @@
 dnl Process this file with autoconf to create configure.
 
 AC_INIT([libmnl], [1.0.1])
-AC_CANONICAL_TARGET
+AC_CANONICAL_HOST
 AC_CONFIG_MACRO_DIR([m4])
 AC_CONFIG_HEADERS([config.h])
 AM_INIT_AUTOMAKE([foreign dist-bzip2 1.6 subdir-objects])
@@ -12,7 +12,7 @@ AC_EXEEXT
 AC_DISABLE_STATIC
 LT_INIT
 CHECK_GCC_FVISIBILITY
-case $target in 
+case "$host" in
 *-*-linux*) ;;
 *) AC_MSG_ERROR([Linux only, dude!]);;
 esac
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: libmnl: build improvements
  2010-12-30 23:43 libmnl: build improvements Jan Engelhardt
  2010-12-30 23:43 ` [PATCH 1/2] build: use AM_CPPFLAGS Jan Engelhardt
  2010-12-30 23:43 ` [PATCH 2/2] build: use only AC_CANONICAL_HOST Jan Engelhardt
@ 2011-01-06  2:21 ` Pablo Neira Ayuso
  2 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2011-01-06  2:21 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: netfilter-devel

On 31/12/10 00:43, Jan Engelhardt wrote:
> The following changes since commit 091286e666a9d34818a875152ac7659b38656f06:
> 
>   build: libmnl 1.0.1 release (2010-12-26 21:17:54 +0100)
> 
> are available in the git repository at:
>   git://dev.medozas.de/libmnl master
> 
> Jan Engelhardt (2):
>       build: use AM_CPPFLAGS
>       build: use only AC_CANONICAL_HOST
> 
>  Make_global.am |    2 +-
>  configure.ac   |    9 +++++----
>  2 files changed, 6 insertions(+), 5 deletions(-)

Applied, thanks Jan.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-01-06  2:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-30 23:43 libmnl: build improvements Jan Engelhardt
2010-12-30 23:43 ` [PATCH 1/2] build: use AM_CPPFLAGS Jan Engelhardt
2010-12-30 23:43 ` [PATCH 2/2] build: use only AC_CANONICAL_HOST Jan Engelhardt
2011-01-06  2:21 ` libmnl: build improvements Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).