From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fwestphal@astaro.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH][RESEND] libxt_time: fix random --datestart skips
Date: Sun, 09 Jan 2011 22:01:59 +0100 [thread overview]
Message-ID: <4D2A2247.10806@netfilter.org> (raw)
In-Reply-To: <1292513328-19072-1-git-send-email-fwestphal@astaro.com>
On 16/12/10 16:28, Florian Westphal wrote:
> Frank Lichtenheld points out that -m time --datestart ...
> sometimes messes up --datestart:
>
> $ iptables -A INPUT -m time --datestart 2010-11-24T16:50:00 -j ACCEPT
> $ iptables-save | grep 11
> -A INPUT -m time --datestart 2010-11-24T16:50:00 -j ACCEPT
> $ iptables-save | iptables-restore
> $ iptables-save | grep 11
> -A INPUT -m time --datestart 2010-11-24T15:50:00 -j ACCEPT
>
> --datestart moved by one hour.
>
> As the --timestart option does not care about DST, always set
> dst=0 when parsing --starttime input.
>
> Reported-by: Frank Lichtenheld <flichtenheld@astaro.com>
> Signed-off-by: Florian Westphal <fwestphal@astaro.com>
Applied, thanks Florian.
prev parent reply other threads:[~2011-01-09 21:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 15:28 [PATCH][RESEND] libxt_time: fix random --datestart skips Florian Westphal
2011-01-09 21:01 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2A2247.10806@netfilter.org \
--to=pablo@netfilter.org \
--cc=fwestphal@astaro.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).