* netfilter: xt_comment: drop unneeded unsigned qualifier
@ 2010-12-26 9:22 Jan Engelhardt
2011-01-12 20:31 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Jan Engelhardt @ 2010-12-26 9:22 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Netfilter Developer Mailing List
parent 0167acf6cbdf1d70d1540e61680d8301c0c388fb (v2.6.37-rc1-237-g0167acf)
commit c21eb58de7b4d9c6bb406fd0b08388e6eb76a106
Author: Jan Engelhardt <jengelh@medozas.de>
Date: Sun Dec 26 10:21:19 2010 +0100
netfilter: xt_comment: drop unneeded unsigned qualifier
Since a string is stored, and not something like a MAC address that
would rely on (un)signedness, drop the qualifier.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
| 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--git a/include/linux/netfilter/xt_comment.h b/include/linux/netfilter/xt_comment.h
index eacfedc..0ea5e79 100644
--- a/include/linux/netfilter/xt_comment.h
+++ b/include/linux/netfilter/xt_comment.h
@@ -4,7 +4,7 @@
#define XT_MAX_COMMENT_LEN 256
struct xt_comment_info {
- unsigned char comment[XT_MAX_COMMENT_LEN];
+ char comment[XT_MAX_COMMENT_LEN];
};
#endif /* XT_COMMENT_H */
--
# Created with git-export-patch
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: netfilter: xt_comment: drop unneeded unsigned qualifier
2010-12-26 9:22 netfilter: xt_comment: drop unneeded unsigned qualifier Jan Engelhardt
@ 2011-01-12 20:31 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2011-01-12 20:31 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Patrick McHardy, Netfilter Developer Mailing List
On 26/12/10 10:22, Jan Engelhardt wrote:
> parent 0167acf6cbdf1d70d1540e61680d8301c0c388fb (v2.6.37-rc1-237-g0167acf)
> commit c21eb58de7b4d9c6bb406fd0b08388e6eb76a106
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date: Sun Dec 26 10:21:19 2010 +0100
>
> netfilter: xt_comment: drop unneeded unsigned qualifier
>
> Since a string is stored, and not something like a MAC address that
> would rely on (un)signedness, drop the qualifier.
>
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Applied for nf-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-12 20:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-26 9:22 netfilter: xt_comment: drop unneeded unsigned qualifier Jan Engelhardt
2011-01-12 20:31 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).