From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_conntrack_tstamp: add flow-based timestamp extension
Date: Fri, 14 Jan 2011 13:15:20 +0100 [thread overview]
Message-ID: <4D303E58.40703@trash.net> (raw)
In-Reply-To: <4D303A7D.30002@netfilter.org>
On 14.01.2011 12:58, Pablo Neira Ayuso wrote:
>>> +static inline
>>> +struct nf_conn_tstamp *nf_ct_tstamp_ext_add(struct nf_conn *ct, gfp_t gfp)
>>> +{
>>> + struct net *net = nf_ct_net(ct);
>>> +
>>> + if (!net->ct.sysctl_tstamp)
>>> + return NULL;
>>> +
>>> + return nf_ct_ext_add(ct, NF_CT_EXT_TSTAMP, gfp);
>>
>> How about making this configurable at compile time to avoid any overhead
>> (memory in ct_extend and runtime) for anyone not needing it like most
>> of the other ct_extend options?
>
> I'm fine with this, I'll add it.
>
> Looking at the source, should we do the same with the accounting? I
> remember that we decided to remove this compile-time option time ago.
I see no reason why not.
next prev parent reply other threads:[~2011-01-14 12:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 12:30 [PATCH] netfilter: nf_conntrack_tstamp: add flow-based timestamp extension Pablo Neira Ayuso
2011-01-13 15:40 ` Pablo Neira Ayuso
2011-01-13 19:00 ` Patrick McHardy
2011-01-13 19:10 ` Patrick McHardy
2011-01-14 11:58 ` Pablo Neira Ayuso
2011-01-14 12:15 ` Patrick McHardy [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-18 19:27 Pablo Neira Ayuso
2011-01-19 15:01 ` Patrick McHardy
2011-01-16 22:33 Pablo Neira Ayuso
2011-01-18 13:59 ` Patrick McHardy
2010-10-24 15:25 Pablo Neira Ayuso
2010-10-25 16:00 ` Patrick McHardy
2010-10-23 17:23 Pablo Neira Ayuso
2010-10-24 1:30 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D303E58.40703@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).