From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Netfilter Development Mailinglist <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH]: netfilter: nf_conntrack: use is_vmalloc_addr()
Date: Fri, 14 Jan 2011 15:46:44 +0100 [thread overview]
Message-ID: <4D3061D4.2020705@trash.net> (raw)
In-Reply-To: <1295015623.3937.23.camel@edumazet-laptop>
Am 14.01.2011 15:33, schrieb Eric Dumazet:
> Le vendredi 14 janvier 2011 à 14:42 +0100, Patrick McHardy a écrit :
>> I'll add this to my tree unless someone spots a bug.
>>
>> netfilter: nf_conntrack: use is_vmalloc_addr()
>>
>> Use is_vmalloc_addr() in nf_ct_free_hashtable() and get rid of
>> the vmalloc flags to indicate that a hash table has been allocated
>> using vmalloc().
>>
>
> Seems fine to me, you could shrink this chunk to one line :
>
> @@ -1271,7 +1271,7 @@ static void nf_conntrack_cleanup_net(struct net *net)
> goto i_see_dead_people;
> }
>
> - nf_ct_free_hashtable(net->ct.hash, net->ct.hash_vmalloc,
> + nf_ct_free_hashtable(net->ct.hash,
> net->ct.htable_size);
Thanks, I've fixed this and committed the patch to my tree.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-01-14 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 13:42 [PATCH]: netfilter: nf_conntrack: use is_vmalloc_addr() Patrick McHardy
2011-01-14 14:33 ` Eric Dumazet
2011-01-14 14:46 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3061D4.2020705@trash.net \
--to=kaber@trash.net \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).